DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Helin" <helin.zhang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] i40e: Steps and required configurations of how to achieve the best performance!
Date: Thu, 16 Oct 2014 00:43:16 +0000	[thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A79C8B2@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1865184.LnymqLhuvV@xps13>

Hi Thomas

Yes, your proposal it the perfect one, also the most complicated one. I was thinking of that one as well, but we did not have enough time for that in our 1.8 timeframe.
In the long run, I agree with you to implement EAL function to access PCI config space directly. I will try to put it in our plan as soon as possible, if no objections.

For now, I think the quickest and easiest way might be to write out a script of using ‘setpci’, the Linux command. It is harmless for our code base, and we can remove it when we have better choice. What do you think?

Thank you very much for the great comments on this topic! I really like it!


From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
Sent: Wednesday, October 15, 2014 5:42 PM
To: Zhang, Helin
Cc: dev@dpdk.org; David Marchand
Subject: Re: [dpdk-dev] i40e: Steps and required configurations of how to achieve the best performance!

Hi Helin,

2014-09-19 03:43, Zhang, Helin:

> My idea on it could be,

> 1. Write a script to use ‘setpci’ to configure pci configuration.

> End user can decide which PCI device needs to be changed.

> 2. Add code to change that PCI configuration in i40e PMD only, as

> it seems nobody else need it till now.

The second solution seems better because more integrated and automatic.

But I would like to have some EAL functions to access to PCI configuration.

These functions would have Linux and BSD implementations.

Then the PMD could change the configuration if it's allowed by a run-time

option and would notify the change with a warning/log.

Thanks for keeping us notified of your progress.



  reply	other threads:[~2014-10-16  0:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17  4:18 Zhang, Helin
2014-09-17  8:33 ` David Marchand
2014-09-17  8:50   ` Zhang, Helin
2014-09-17 14:03     ` David Marchand
2014-09-18  2:39       ` Zhang, Helin
2014-09-18  8:57         ` David Marchand
2014-09-19  3:43           ` Zhang, Helin
2014-10-15  9:41             ` Thomas Monjalon
2014-10-16  0:43               ` Zhang, Helin [this message]
2015-02-09 12:12                 ` David Marchand
2015-02-10  0:27                   ` Zhang, Helin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A79C8B2@SHSMSX104.ccr.corp.intel.com \
    --to=helin.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).