From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5A82C7E75 for ; Thu, 16 Oct 2014 02:47:50 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 15 Oct 2014 17:55:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,728,1406617200"; d="scan'208";a="606139158" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 15 Oct 2014 17:55:39 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 15 Oct 2014 17:55:40 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 15 Oct 2014 17:55:39 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.230]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.203]) with mapi id 14.03.0195.001; Thu, 16 Oct 2014 08:55:38 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville Thread-Index: AQHP6CZMhgwHBKWhOUCv8VtLaEWvQJwwuUZw///ViICAAVgJsA== Date: Thu, 16 Oct 2014 00:55:38 +0000 Message-ID: References: <1413342878-18584-1-git-send-email-jijiang.liu@intel.com> <1416793.NVMu20orOd@xps13> In-Reply-To: <1416793.NVMu20orOd@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Oct 2014 00:47:50 -0000 Hi Thomas Thank you very much for the detailed guidance! It is really helpful for me. Regards, Helin > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, October 15, 2014 8:22 PM > To: Zhang, Helin > Cc: dev@dpdk.org; Liu, Jijiang > Subject: Re: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville >=20 > Helin, >=20 > As you are in charge of i40e, here are 2 tips to acknowledge patches: >=20 > 1) title should take this format: > i40e: add Rx error statistics >=20 > > Acked-by: Helin Zhang >=20 > 2) This line should be added right after the Signed-off-by. > And the rest of the email (patch body) can be removed. > This way, your answer would be faster to read. >=20 > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu > > > Sent: Wednesday, October 15, 2014 11:15 AM > > > To: dev@dpdk.org > > > Subject: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville >=20 > This header is not needed also. >=20 > > > This patch adds incoming packet error statistics in the i40e_ethdev.c= file. > > > > > > Signed-off-by: Jijiang Liu >=20 > [I remove the rest of the original email because I have no comment on it] >=20 > Thanks > -- > Thomas