[dpdk-dev] [PATCH] Add Rx error statistics for Fortville

[dpdk-dev] [PATCH] Add Rx error statistics for Fortville

[Jijiang Liu]

This patch adds incoming packet error statistics in the i40e_ethdev.c file.

Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
---
 lib/librte_pmd_i40e/i40e_ethdev.c |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c
index 46c43a7..dbf231f 100644
--- a/lib/librte_pmd_i40e/i40e_ethdev.c
+++ b/lib/librte_pmd_i40e/i40e_ethdev.c
@@ -1274,6 +1274,9 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 
 	pf->offset_loaded = true;
 
+	if (pf->main_vsi)
+		i40e_update_vsi_stats(pf->main_vsi);
+
 	stats->ipackets = ns->eth.rx_unicast + ns->eth.rx_multicast +
 						ns->eth.rx_broadcast;
 	stats->opackets = ns->eth.tx_unicast + ns->eth.tx_multicast +
@@ -1283,8 +1286,12 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 	stats->oerrors  = ns->eth.tx_errors;
 	stats->imcasts  = ns->eth.rx_multicast;
 
-	if (pf->main_vsi)
-		i40e_update_vsi_stats(pf->main_vsi);
+	/* Rx Errors */
+	stats->ibadcrc  = ns->crc_errors;
+	stats->ibadlen  = ns->rx_length_errors + ns->rx_undersize +
+			ns->rx_oversize + ns->rx_fragments + ns->rx_jabber;
+	stats->imissed  = ns->eth.rx_discards;
+	stats->ierrors  = stats->ibadcrc + stats->ibadlen + stats->imissed;
 
 	PMD_DRV_LOG(DEBUG, "***************** PF stats start *******************");
 	PMD_DRV_LOG(DEBUG, "rx_bytes:            %lu", ns->eth.rx_bytes);
-- 
1.7.7.6

Re: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville

[Zhang, Helin]

Acked-by: Helin Zhang <helin.zhang@intel.com>

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu
> Sent: Wednesday, October 15, 2014 11:15 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville
> 
> This patch adds incoming packet error statistics in the i40e_ethdev.c file.
> 
> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> ---
>  lib/librte_pmd_i40e/i40e_ethdev.c |   11 +++++++++--
>  1 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c
> b/lib/librte_pmd_i40e/i40e_ethdev.c
> index 46c43a7..dbf231f 100644
> --- a/lib/librte_pmd_i40e/i40e_ethdev.c
> +++ b/lib/librte_pmd_i40e/i40e_ethdev.c
> @@ -1274,6 +1274,9 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct
> rte_eth_stats *stats)
> 
>  	pf->offset_loaded = true;
> 
> +	if (pf->main_vsi)
> +		i40e_update_vsi_stats(pf->main_vsi);
> +
>  	stats->ipackets = ns->eth.rx_unicast + ns->eth.rx_multicast +
>  						ns->eth.rx_broadcast;
>  	stats->opackets = ns->eth.tx_unicast + ns->eth.tx_multicast + @@
> -1283,8 +1286,12 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct
> rte_eth_stats *stats)
>  	stats->oerrors  = ns->eth.tx_errors;
>  	stats->imcasts  = ns->eth.rx_multicast;
> 
> -	if (pf->main_vsi)
> -		i40e_update_vsi_stats(pf->main_vsi);
> +	/* Rx Errors */
> +	stats->ibadcrc  = ns->crc_errors;
> +	stats->ibadlen  = ns->rx_length_errors + ns->rx_undersize +
> +			ns->rx_oversize + ns->rx_fragments + ns->rx_jabber;
> +	stats->imissed  = ns->eth.rx_discards;
> +	stats->ierrors  = stats->ibadcrc + stats->ibadlen + stats->imissed;
> 
>  	PMD_DRV_LOG(DEBUG, "***************** PF stats start
> *******************");
>  	PMD_DRV_LOG(DEBUG, "rx_bytes:            %lu",
> ns->eth.rx_bytes);
> --
> 1.7.7.6

Re: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville

[Thomas Monjalon]

Helin,

As you are in charge of i40e, here are 2 tips to acknowledge patches:

1) title should take this format:
	i40e: add Rx error statistics

> Acked-by: Helin Zhang <helin.zhang@intel.com>

2) This line should be added right after the Signed-off-by.
And the rest of the email (patch body) can be removed.
This way, your answer would be faster to read.

> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu
> > Sent: Wednesday, October 15, 2014 11:15 AM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville

This header is not needed also.

> > This patch adds incoming packet error statistics in the i40e_ethdev.c file.
> > 
> > Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>

[I remove the rest of the original email because I have no comment on it]

Thanks
-- 
Thomas

Re: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville

[Zhang, Helin]

Hi Thomas

Thank you very much for the detailed guidance! It is really helpful for me.

Regards,
Helin

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, October 15, 2014 8:22 PM
> To: Zhang, Helin
> Cc: dev@dpdk.org; Liu, Jijiang
> Subject: Re: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville
> 
> Helin,
> 
> As you are in charge of i40e, here are 2 tips to acknowledge patches:
> 
> 1) title should take this format:
> 	i40e: add Rx error statistics
> 
> > Acked-by: Helin Zhang <helin.zhang@intel.com>
> 
> 2) This line should be added right after the Signed-off-by.
> And the rest of the email (patch body) can be removed.
> This way, your answer would be faster to read.
> 
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu
> > > Sent: Wednesday, October 15, 2014 11:15 AM
> > > To: dev@dpdk.org
> > > Subject: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville
> 
> This header is not needed also.
> 
> > > This patch adds incoming packet error statistics in the i40e_ethdev.c file.
> > >
> > > Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> 
> [I remove the rest of the original email because I have no comment on it]
> 
> Thanks
> --
> Thomas

Re: [dpdk-dev] [PATCH] Add Rx error statistics for Fortville

[Thomas Monjalon]

> > This patch adds incoming packet error statistics in the i40e_ethdev.c file.
> > 
> > Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> 
> Acked-by: Helin Zhang <helin.zhang@intel.com>

Applied

Thanks
-- 
Thomas