From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 127BE685D for ; Mon, 20 Oct 2014 03:06:07 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 19 Oct 2014 18:14:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,749,1406617200"; d="scan'208";a="616960087" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by fmsmga002.fm.intel.com with ESMTP; 19 Oct 2014 18:14:15 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 20 Oct 2014 09:11:39 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.174]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.207]) with mapi id 14.03.0195.001; Mon, 20 Oct 2014 09:11:38 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2 2/3] i40e: extern two functions and relevant macros Thread-Index: AQHP6k1VkAk1tgzES0udHF6E86kj4Zw4LysA Date: Mon, 20 Oct 2014 01:11:37 +0000 Message-ID: References: <1411089280-23595-1-git-send-email-helin.zhang@intel.com> <1411089280-23595-3-git-send-email-helin.zhang@intel.com> <7641617.oBnDKljgVa@xps13> In-Reply-To: <7641617.oBnDKljgVa@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 2/3] i40e: extern two functions and relevant macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Oct 2014 01:06:08 -0000 Hi Thomas > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Saturday, October 18, 2014 4:59 AM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 2/3] i40e: extern two functions and rel= evant > macros >=20 > 2014-09-19 09:14, Helin Zhang: > > To reuse code, 'i40e_config_hena()' and 'i40e_parse_hena()' and their > > relevant macros need to be extern, and then can be used for both PF > > and VF parts. > > > > Signed-off-by: Helin Zhang > > Reviewed-by: Cunming Liang > > Reviewed-by: Jijiang Liu > [...] > > +#define I40E_RSS_OFFLOAD_ALL ( \ > > + ETH_RSS_NONF_IPV4_UDP | \ > > + ETH_RSS_NONF_IPV4_TCP | \ > > + ETH_RSS_NONF_IPV4_SCTP | \ > > + ETH_RSS_NONF_IPV4_OTHER | \ > > + ETH_RSS_FRAG_IPV4 | \ > > + ETH_RSS_NONF_IPV6_UDP | \ > > + ETH_RSS_NONF_IPV6_TCP | \ > > + ETH_RSS_NONF_IPV6_SCTP | \ > > + ETH_RSS_NONF_IPV6_OTHER | \ > > + ETH_RSS_FRAG_IPV6 | \ > > + ETH_RSS_L2_PAYLOAD) > > + > > +/* All bits of RSS hash enable */ > > +#define I40E_RSS_HENA_ALL ( \ > > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_UDP) | \ > > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_TCP) | \ > > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_SCTP) | \ > > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV4_OTHER) | \ > > + (1ULL << I40E_FILTER_PCTYPE_FRAG_IPV4) | \ > > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_UDP) | \ > > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_TCP) | \ > > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_SCTP) | \ > > + (1ULL << I40E_FILTER_PCTYPE_NONF_IPV6_OTHER) | \ > > + (1ULL << I40E_FILTER_PCTYPE_FRAG_IPV6) | \ > > + (1ULL << I40E_FILTER_PCTYPE_FCOE_OX) | \ > > + (1ULL << I40E_FILTER_PCTYPE_FCOE_RX) | \ > > + (1ULL << I40E_FILTER_PCTYPE_FCOE_OTHER) | \ > > + (1ULL << I40E_FILTER_PCTYPE_L2_PAYLOAD)) >=20 > You've added the constants in the .h file but you forgot to remove them f= rom > the .c file. Ohh, yes, you are right! Thank you for the good catch! And sorry for the in= convenience! >=20 > -- > Thomas Regards, Helin