From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 8BE3258D2 for ; Tue, 28 Oct 2014 01:25:21 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 27 Oct 2014 17:34:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,799,1406617200"; d="scan'208";a="621740653" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by fmsmga002.fm.intel.com with ESMTP; 27 Oct 2014 17:34:01 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 28 Oct 2014 08:33:28 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.174]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.13]) with mapi id 14.03.0195.001; Tue, 28 Oct 2014 08:33:27 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of redirection table Thread-Index: AQHP7Zkufu3qEL3+S0+ks7KzOBBUo5xErn9A Date: Tue, 28 Oct 2014 00:33:26 +0000 Message-ID: References: <1411634427-746-1-git-send-email-helin.zhang@intel.com> <1411634427-746-5-git-send-email-helin.zhang@intel.com> <4337777.fZJZ2Jprv9@xps13> In-Reply-To: <4337777.fZJZ2Jprv9@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of redirection table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Oct 2014 00:25:22 -0000 Hi Thomas Sorry, I should have answer your comments together with my reworking the la= test patch set. Please see my answers for your comments! I really appreciate your comments! > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, October 22, 2014 4:54 AM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple size= s of > redirection table >=20 > 2014-09-25 16:40, Helin Zhang: > > To support possible different sizes of redirection table, structures > > and functions need to be redefined. In detail, > > * 'struct rte_eth_rss_reta' has been redefined. > > * 'uint16_t reta_size' has been added into > > 'struct rte_eth_dev_info'. > > * Updating/querying reta have been reimplemented with one > > more parameter of redirection table size. > > > > v2 changes: > > * Put changes for supporting multiple sizes of reta in > > ethdev into a single patch. >=20 > In order to allow usage of git bisect, compilation must not be broken, ev= en inside > a patchset. > So when refactoring an existing API, you must adapt the dependent code in= the > same patch. > To make things easy to review, please try to change API incrementally wit= h good > explanation of why each change is needed. OK. The patch set has been reworked to get all patches compiled well. >=20 > > /* Definitions used for redirection table entry size */ -#define > > ETH_RSS_RETA_NUM_ENTRIES 128 > > -#define ETH_RSS_RETA_MAX_QUEUE 16 > > +#define ETH_RSS_RETA_SIZE_64 64 > > +#define ETH_RSS_RETA_SIZE_128 128 > > +#define ETH_RSS_RETA_SIZE_512 512 > > + > > +#define RTE_BIT_WIDTH_64 (CHAR_BIT * sizeof(uint64_t)) >=20 > Are these constants really needed? These constants were defined for the third input parameter of rte_eth_dev_rss_reta_update() and rte_eth_dev_rss_reta_query(). End users n= eed to give the correct reta size listed as above, as other values is not valid= . So it would be better to list the valid reta sizes in macros here. >=20 > > /** > > - * A structure used to configure Redirection Table of the Receive > > Side > > - * Scaling (RSS) feature of an Ethernet port. > > + * A structure used to configure 64 entries of Redirection Table of > > + the > > + * Receive Side Scaling (RSS) feature of an Ethernet port. To > > + configure > > + * more than 64 entries supported by hardware, an array of this > > + structure > > + * is needed. > > */ >=20 > Explaining the array of 64 entries could be useful in commit log. > Please don't forget to answer the "why" question in commit logs. OK. Rework for this has been done in the latest version of patch set. >=20 > Thanks > -- > Thomas Thanks, Helin