From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id BD5347E62 for ; Tue, 28 Oct 2014 13:27:57 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 28 Oct 2014 05:36:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,802,1406617200"; d="scan'208";a="626883079" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga002.jf.intel.com with ESMTP; 28 Oct 2014 05:36:42 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 28 Oct 2014 20:36:41 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.174]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.207]) with mapi id 14.03.0195.001; Tue, 28 Oct 2014 20:36:40 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of redirection table Thread-Index: AQHP7Zkufu3qEL3+S0+ks7KzOBBUo5xErn9AgAAe6wCAAKLHEP//f5YAgACLybA= Date: Tue, 28 Oct 2014 12:36:40 +0000 Message-ID: References: <1411634427-746-1-git-send-email-helin.zhang@intel.com> <3230077.QOtjOU5lvA@xps13> <78583890.WXH3mxH3Sc@xps13> In-Reply-To: <78583890.WXH3mxH3Sc@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of redirection table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Oct 2014 12:27:58 -0000 Hi Thomas > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, October 28, 2014 8:13 PM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple size= s of > redirection table >=20 > 2014-10-28 12:00, Zhang, Helin: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2014-10-28 00:33, Zhang, Helin: > > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > > 2014-09-25 16:40, Helin Zhang: > > > > > > /* Definitions used for redirection table entry size */ > > > > > > -#define ETH_RSS_RETA_NUM_ENTRIES 128 > > > > > > -#define ETH_RSS_RETA_MAX_QUEUE 16 > > > > > > +#define ETH_RSS_RETA_SIZE_64 64 #define > > > > > > +ETH_RSS_RETA_SIZE_128 128 #define ETH_RSS_RETA_SIZE_512 512 > [...] > > > By the way, why only these values are allowed? > > > > It depends on hardware, 1G/10G hardware supports 128 reta size only, > > 40G hardware supports 512 or 128 depends on hardware configuration, > > 40G VF hardware supports 64. If more is introduced in the future, more > > values can be added later. It will return with errors if reta size is n= ot supported > for specific hardware. >=20 > So maybe it should be the responsibility of the driver to use the right v= alue. This > kind of hardware differences should be abstracted for the application. > If the application need to know the size, a "get" function could be provi= ded. Yes, the size can be gotten by ops of 'dev_infos_get'. But if end users kno= w the size of a specific port, he can just use these macros directly without gett= ing it from somewhere. >=20 > -- > Thomas Regards, Helin