From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E6DFD7E9A for ; Tue, 28 Oct 2014 14:12:09 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 28 Oct 2014 06:19:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,802,1406617200"; d="scan'208";a="597635625" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga001.jf.intel.com with ESMTP; 28 Oct 2014 06:20:51 -0700 Received: from pgsmsx106.gar.corp.intel.com (10.221.44.98) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 28 Oct 2014 21:20:50 +0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by pgsmsx106.gar.corp.intel.com (10.221.44.98) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 28 Oct 2014 21:20:50 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.174]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.13]) with mapi id 14.03.0195.001; Tue, 28 Oct 2014 21:20:48 +0800 From: "Zhang, Helin" To: "Richardson, Bruce" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of redirection table Thread-Index: AQHP8rH9vHAwS0E8AEejVd9Rez0qUw== Date: Tue, 28 Oct 2014 13:20:49 +0000 Message-ID: References: <1411634427-746-1-git-send-email-helin.zhang@intel.com> <4337777.fZJZ2Jprv9@xps13> <3230077.QOtjOU5lvA@xps13> <59AF69C657FD0841A61C55336867B5B034434191@IRSMSX103.ger.corp.intel.com> In-Reply-To: <59AF69C657FD0841A61C55336867B5B034434191@IRSMSX103.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of redirection table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Oct 2014 13:12:10 -0000 Hi Bruce > -----Original Message----- > From: Richardson, Bruce > Sent: Tuesday, October 28, 2014 6:18 PM > To: Thomas Monjalon; Zhang, Helin > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple size= s of > redirection table >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Tuesday, October 28, 2014 10:10 AM > > To: Zhang, Helin > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple > > sizes of redirection table > > > > 2014-10-28 00:33, Zhang, Helin: > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > 2014-09-25 16:40, Helin Zhang: > > > > > /* Definitions used for redirection table entry size */ > > > > > -#define ETH_RSS_RETA_NUM_ENTRIES 128 > > > > > -#define ETH_RSS_RETA_MAX_QUEUE 16 > > > > > +#define ETH_RSS_RETA_SIZE_64 64 #define ETH_RSS_RETA_SIZE_128 > > > > > +128 #define ETH_RSS_RETA_SIZE_512 512 > > > > > + > > > > > +#define RTE_BIT_WIDTH_64 (CHAR_BIT * sizeof(uint64_t)) > > > > > > > > Are these constants really needed? > > > > > > These constants were defined for the third input parameter of > > > rte_eth_dev_rss_reta_update() and rte_eth_dev_rss_reta_query(). End > > > users > > need > > > to give the correct reta size listed as above, as other values is > > > not valid. So it > > would be > > > better to list the valid reta sizes in macros here. > > > If only limited range of values are allowed, would an enum work better th= an a set > of macros? Good idea! Any other comments for this from other guys? >=20 > > OK, so you should explain that only these values are allowed. > > In general, it's something we explain in the comment of the function. > > > > By the way, why only these values are allowed? Regards, Helin