From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 1D0997F8C for ; Wed, 29 Oct 2014 09:11:34 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 29 Oct 2014 01:20:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,808,1406617200"; d="scan'208";a="622625698" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by fmsmga002.fm.intel.com with ESMTP; 29 Oct 2014 01:20:23 -0700 Received: from kmsmsx151.gar.corp.intel.com (172.21.73.86) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 29 Oct 2014 16:18:59 +0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 29 Oct 2014 16:18:59 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.174]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.44]) with mapi id 14.03.0195.001; Wed, 29 Oct 2014 16:18:58 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of redirection table Thread-Index: AQHP8rq4ABJ1NqerFEuVi0UcpuFlSZxGvCDQ Date: Wed, 29 Oct 2014 08:18:57 +0000 Message-ID: References: <1411634427-746-1-git-send-email-helin.zhang@intel.com> <59AF69C657FD0841A61C55336867B5B034434191@IRSMSX103.ger.corp.intel.com> <16840005.4l2yIG62TI@xps13> In-Reply-To: <16840005.4l2yIG62TI@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple sizes of redirection table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Oct 2014 08:11:35 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, October 28, 2014 10:23 PM > To: Zhang, Helin > Cc: Richardson, Bruce; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: support of multiple size= s of > redirection table >=20 > 2014-10-28 13:20, Zhang, Helin: > > From: Richardson, Bruce > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > > > 2014-10-28 00:33, Zhang, Helin: > > > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > > > 2014-09-25 16:40, Helin Zhang: > > > > > > > /* Definitions used for redirection table entry size */ > > > > > > > -#define ETH_RSS_RETA_NUM_ENTRIES 128 > > > > > > > -#define ETH_RSS_RETA_MAX_QUEUE 16 > > > > > > > +#define ETH_RSS_RETA_SIZE_64 64 #define > > > > > > > +ETH_RSS_RETA_SIZE_128 128 #define ETH_RSS_RETA_SIZE_512 512 > > > > > > > + > > > > > > > +#define RTE_BIT_WIDTH_64 (CHAR_BIT * sizeof(uint64_t)) > > > > > > > > > > > > Are these constants really needed? > > > > > > > > > > These constants were defined for the third input parameter of > > > > > rte_eth_dev_rss_reta_update() and rte_eth_dev_rss_reta_query(). > > > > > End users need to give the correct reta size listed as above, as > > > > > other values is not valid. So it would be better to list the > > > > > valid reta sizes in macros here. > > > > > > > If only limited range of values are allowed, would an enum work > > > better than a set of macros? > > > > Good idea! Any other comments for this from other guys? >=20 > I would prefer the API to be independent of the hardware capabilities. Let keep it as it is, and add more possible comments somewhere. >=20 > -- > Thomas Regards, Helin