From: "Zhang, Helin" <helin.zhang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
Ariel Rodriguez <arodriguez@callistech.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] SEGMENTATION FAULT in kni example : kni_free_kni() call
Date: Wed, 29 Oct 2014 08:42:05 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7ACA02@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <5223956.lFdNUbkl0D@xps13>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Wednesday, October 29, 2014 4:35 PM
> To: Ariel Rodriguez
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] SEGMENTATION FAULT in kni example : kni_free_kni()
> call
>
> Hi,
>
> 2014-10-28 23:07, Ariel Rodriguez:
> > Hi, im trying the kni example. When i hit ctrl-c in the terminal
> > stopping the example, the os signals with a segmentation fault.
> [...]
> > The following change fix that issue:
> >
> > static int kni_free_kni(uint8_t port_id) { uint8_t i; struct
> > kni_port_params **p = kni_port_params_array;
> >
> > if (port_id >= RTE_MAX_ETHPORTS || !p[port_id]) return -1;
> >
> > ++ for (i = 0; i < p[port_id]->nb_kni; i++) {
> > ++ rte_kni_release(p[port_id]->kni[i]);
> > ++ p[port_id]->kni[i] = NULL;
Great to see it! That would be a perfect fix for it.
> > }
> > rte_eth_dev_stop(port_id);
> >
> > return 0;
> > }
> >
> > Sorry for the basic of my fix ... i dont know the correct style to
> > report this kind of issues... im just a user of the dpdk library ...
> > but i meet this bug ...
>
> Thank you for reporting it.
> If you want to send an applicable patch, the procedure is described here:
> http://dpdk.org/dev#send
>
> --
> Thomas
Regards,
Helin
prev parent reply other threads:[~2014-10-29 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 2:07 Ariel Rodriguez
2014-10-29 8:35 ` Thomas Monjalon
2014-10-29 8:42 ` Zhang, Helin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A7ACA02@SHSMSX104.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=arodriguez@callistech.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).