From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 19339677B for ; Fri, 31 Oct 2014 02:32:14 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 30 Oct 2014 18:41:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,290,1413270000"; d="scan'208";a="599456208" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga001.jf.intel.com with ESMTP; 30 Oct 2014 18:41:11 -0700 Received: from kmsmsx152.gar.corp.intel.com (172.21.73.87) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 31 Oct 2014 09:39:47 +0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by KMSMSX152.gar.corp.intel.com (172.21.73.87) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 31 Oct 2014 09:39:47 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.174]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.207]) with mapi id 14.03.0195.001; Fri, 31 Oct 2014 09:39:44 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v3 7/8] ethdev: support of multiple sizes of redirection table Thread-Index: AQHP8fGzAH2dotGp9Eu7EEx+dND6JJxEqb/QgAAZe4CABK9cMA== Date: Fri, 31 Oct 2014 01:39:44 +0000 Message-ID: References: <1411634427-746-1-git-send-email-helin.zhang@intel.com> <2549150.oVMv5n2oYl@xps13> <1959774.p5xijEU5zU@xps13> In-Reply-To: <1959774.p5xijEU5zU@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 7/8] ethdev: support of multiple sizes of redirection table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Oct 2014 01:32:15 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, October 28, 2014 6:05 PM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 7/8] ethdev: support of multiple sizes = of > redirection table >=20 > 2014-10-28 00:37, Zhang, Helin: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2014-10-22 19:53, Helin Zhang: > > > > +#define RTE_BIT_WIDTH_64 (CHAR_BIT * sizeof(uint64_t)) > > > > > > How can it be different of 64? > > > Using 64 would be simpler to understand than RTE_BIT_WIDTH_64. > > > > > > > + uint8_t reta[RTE_BIT_WIDTH_64]; /**< 64 redirection table entries= . */ > > We always try to use macro in code to replace numeric, this can get the= numeric > more understandable. >=20 > How bit width 64 is more understandable than 64? > Especially when you count a number of entries, not a bit width. > RETA_ENTRIES_MAX would be more understandable. Renaming the macro is needed. I plan to rename it to RTE_RETA_GROUP_SIZE, as it is a group of 64 reta entries, but not the maximum number of valid en= tries. >=20 > -- > Thomas Regards, Helin