From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 0758A7F80 for ; Thu, 6 Nov 2014 01:53:39 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 05 Nov 2014 17:01:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,322,1413270000"; d="scan'208";a="603140081" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by orsmga001.jf.intel.com with ESMTP; 05 Nov 2014 17:02:50 -0800 Received: from pgsmsx102.gar.corp.intel.com (10.221.44.80) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 6 Nov 2014 09:02:09 +0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 6 Nov 2014 09:02:09 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.174]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.202]) with mapi id 14.03.0195.001; Thu, 6 Nov 2014 09:02:08 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v4 7/8] ethdev: support of multiple sizes of redirection table Thread-Index: AQHP+TqJhK0Q6AAk6USVG1x7RuYnspxSxenw Date: Thu, 6 Nov 2014 01:02:07 +0000 Message-ID: References: <1413978810-24610-1-git-send-email-helin.zhang@intel.com> <1414746215-17327-1-git-send-email-helin.zhang@intel.com> <1414746215-17327-8-git-send-email-helin.zhang@intel.com> <3547625.yeCIkN20CJ@xps13> In-Reply-To: <3547625.yeCIkN20CJ@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4 7/8] ethdev: support of multiple sizes of redirection table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Nov 2014 00:53:40 -0000 Hi Thomas > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, November 6, 2014 4:53 AM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 7/8] ethdev: support of multiple sizes = of > redirection table >=20 > 2014-10-31 17:03, Helin Zhang: > > #define ETH_RSS_RETA_SIZE_64 64 > > #define ETH_RSS_RETA_SIZE_128 128 > > #define ETH_RSS_RETA_SIZE_512 512 >=20 > Are these values still needed? It was widely used in igb/ixgbe/i40e code, and app/testpmd. It is good to b= e kept there, though we can define them separately in each component. This would be more = convenient for PMDs and user applications. > Why 256 is forbidden? 256 is not a valid table size of current supported NICs, for other/future N= IC which supports this size, it can be added later as needed. > Maybe that some comments are needed here. Comments might not be needed, as their names tell us what they are clearly.= Did you mean any other annotations to be added for these macros? I am open for that to a= dd any good annotations for them. >=20 > > +#define RTE_RETA_GROUP_SIZE 64