From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id F06922E89 for ; Thu, 6 Nov 2014 09:45:29 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 06 Nov 2014 00:54:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,324,1413270000"; d="scan'208";a="603324018" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga001.jf.intel.com with ESMTP; 06 Nov 2014 00:54:54 -0800 Received: from pgsmsx104.gar.corp.intel.com (10.221.44.91) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 6 Nov 2014 16:52:57 +0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by PGSMSX104.gar.corp.intel.com (10.221.44.91) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 6 Nov 2014 16:52:56 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.174]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.207]) with mapi id 14.03.0195.001; Thu, 6 Nov 2014 16:52:55 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v4 7/8] ethdev: support of multiple sizes of redirection table Thread-Index: AQHP+TqJhK0Q6AAk6USVG1x7RuYnspxSxenw///6LgCAAIkWUA== Date: Thu, 6 Nov 2014 08:52:55 +0000 Message-ID: References: <1413978810-24610-1-git-send-email-helin.zhang@intel.com> <3547625.yeCIkN20CJ@xps13> <3931991.XHvGI58gnD@xps13> In-Reply-To: <3931991.XHvGI58gnD@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4 7/8] ethdev: support of multiple sizes of redirection table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Nov 2014 08:45:30 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, November 6, 2014 4:33 PM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 7/8] ethdev: support of multiple sizes = of > redirection table >=20 > 2014-11-06 01:02, Zhang, Helin: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2014-10-31 17:03, Helin Zhang: > > > > #define ETH_RSS_RETA_SIZE_64 64 > > > > #define ETH_RSS_RETA_SIZE_128 128 #define ETH_RSS_RETA_SIZE_512 > > > > 512 > > > > > > Are these values still needed? > > > > It was widely used in igb/ixgbe/i40e code, and app/testpmd. It is good > > to be kept there, though we can define them separately in each > > component. This would be more convenient for PMDs and user applications= . >=20 > If it should be used by applications, it must stay in ethdev. Good to get it aligned with us. >=20 > > > Why 256 is forbidden? > > > > 256 is not a valid table size of current supported NICs, for > > other/future NIC which supports this size, it can be added later as nee= ded. >=20 > The problem is that we don't know which value is supported for each drive= r. > You should add a comment like this: > /**@{ > * Some RSS RETA sizes may be not supported by some drivers. > * Check in the PMD documentation. > */ > #define ETH_RSS_RETA_SIZE_64 64 > #define ETH_RSS_RETA_SIZE_128 128 > #define ETH_RSS_RETA_SIZE_512 512 > /**@}*/ In rte_ethdev.h, there is comments for rte_eth_dev_rss_reta_update() and rte_eth_dev_rss_reta_query() that the reta table size can be queried by rte_eth_dev_info_get(). So the end users could know the reta size of each NIC by reading its datash= eet, or call that function to query the size directly. The macros defined here let the reta size more straightforward, and easy to= use. OK, it is good to add some annotations here. Thanks! >=20 > And then add some comments in the PMD to describe the supported sizes. >=20 > > > Maybe that some comments are needed here. > > > > Comments might not be needed, as their names tell us what they are > > clearly. Did you mean any other annotations to be added for these > > macros? I am open for that to add any good annotations for them. >=20 > We just have to keep in mind that the API reference for users is in doxyg= en. > Some details are obvious for you but not clear for the user, especially i= f he > doesn't care about i40e. >=20 > Thanks > -- > Thomas Regards, Helin