From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 604097E80 for ; Thu, 6 Nov 2014 09:49:03 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 06 Nov 2014 00:58:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,324,1413270000"; d="scan'208";a="618076227" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by fmsmga001.fm.intel.com with ESMTP; 06 Nov 2014 00:58:03 -0800 Received: from pgsmsx106.gar.corp.intel.com (10.221.44.98) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 6 Nov 2014 16:54:56 +0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by pgsmsx106.gar.corp.intel.com (10.221.44.98) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 6 Nov 2014 16:54:57 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.174]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.202]) with mapi id 14.03.0195.001; Thu, 6 Nov 2014 16:54:55 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v5 2/5] ethdev: add enum type and relevant structures for hash filter control Thread-Index: AQHP9zv1q1ow4Cmu+UqdYuQikZttDJxS9cQA///REQCAAIknQA== Date: Thu, 6 Nov 2014 08:54:55 +0000 Message-ID: References: <1413180766-12211-1-git-send-email-helin.zhang@intel.com> <1845096.HFlylc4sxo@xps13> <1716176.vfqLo0fjgC@xps13> In-Reply-To: <1716176.vfqLo0fjgC@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v5 2/5] ethdev: add enum type and relevant structures for hash filter control X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Nov 2014 08:49:03 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, November 6, 2014 4:43 PM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 2/5] ethdev: add enum type and relevant > structures for hash filter control >=20 > 2014-11-06 03:41, Zhang, Helin: > > > > +/** > > > > + * A structure used to set or get filter swap information, to > > > > +support > > > > + * 'RTE_ETH_FILTER_HASH', > > > > +'RTE_ETH_FILTER_GET/RTE_ETH_FILTER_SET', > > > > + * with information type > 'RTE_ETH_HASH_FILTER_INFO_TYPE_FILTER_SWAP'. > > > > + */ > > > > +struct rte_eth_filter_swap_info { > > > > + /**< Packet classification type, defined in rte_ethdev.h */ > > > > + uint8_t pctype; > > > > + /**< Offset of the 1st field of the 1st couple to be swapped. */ > > > > + uint8_t off0_src0; > > > > + /**< Offset of the 2nd field of the 1st couple to be swapped. */ > > > > + uint8_t off0_src1; > > > > + /**< Field length of the first couple. */ > > > > + uint8_t len0; > > > > + /**< Offset of the 1st field of the 2nd couple to be swapped. */ > > > > + uint8_t off1_src0; > > > > + /**< Offset of the 2nd field of the 2nd couple to be swapped. */ > > > > + uint8_t off1_src1; > > > > + /**< Field length of the second couple. */ > > > > + uint8_t len1; > > > > +}; > > > > > > I guess it would be easier to understand if > > > RTE_ETH_HASH_FILTER_INFO_TYPE_FILTER_SWAP was defined previously. > > > > It has already been defined before this structure definition. > > I don't think I have understood your idea. Could you help to explain mo= re? > Thanks! >=20 > By "defined", I mean "explained". What is the action of swap filter? > You offer new features in API without explaining them. It's probably obvi= ous for > you but not for me. Yes, they should be explained. >=20 > -- > Thomas Regards, Helin