From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D69CE590B for ; Sat, 8 Nov 2014 05:43:48 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 07 Nov 2014 20:46:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="413384224" Received: from kmsmsx152.gar.corp.intel.com ([172.21.73.87]) by FMSMGA003.fm.intel.com with ESMTP; 07 Nov 2014 20:44:40 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by KMSMSX152.gar.corp.intel.com (172.21.73.87) with Microsoft SMTP Server (TLS) id 14.3.195.1; Sat, 8 Nov 2014 07:26:18 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.174]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.207]) with mapi id 14.03.0195.001; Sat, 8 Nov 2014 07:26:17 +0800 From: "Zhang, Helin" To: Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [PATCH] app,examples: remove references to drivers config Thread-Index: AQHP+olkZHuhB43Nxk+MqHwC+OzVPpxVzw1w Date: Fri, 7 Nov 2014 23:26:16 +0000 Message-ID: References: <1404374093-29710-1-git-send-email-helin.zhang@intel.com> <1415364512-9918-1-git-send-email-thomas.monjalon@6wind.com> In-Reply-To: <1415364512-9918-1-git-send-email-thomas.monjalon@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app, examples: remove references to drivers config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Nov 2014 04:43:50 -0000 Acked-by: Helin Zhang With minor changes suggested: 'devices' -> 'device'? > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, November 7, 2014 8:49 PM > To: dev@dpdk.org > Cc: Zhang, Helin > Subject: [PATCH] app,examples: remove references to drivers config >=20 > These references to drivers break the layering isolation between applicat= ion and > drivers. >=20 > Signed-off-by: Thomas Monjalon > --- > app/test-pmd/testpmd.c | 7 +------ > examples/exception_path/main.c | 4 +--- > examples/kni/main.c | 4 +--- > 3 files changed, 3 insertions(+), 12 deletions(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > f76406f..c373e3a 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1870,12 +1870,7 @@ main(int argc, char** argv) >=20 > nb_ports =3D (portid_t) rte_eth_dev_count(); > if (nb_ports =3D=3D 0) > - rte_exit(EXIT_FAILURE, "No probed ethernet devices - " > - "check that " > - "CONFIG_RTE_LIBRTE_IGB_PMD=3Dy and that " > - "CONFIG_RTE_LIBRTE_EM_PMD=3Dy and that " > - "CONFIG_RTE_LIBRTE_IXGBE_PMD=3Dy in your " > - "configuration file\n"); > + rte_exit(EXIT_FAILURE, "No probed ethernet devices\n"); >=20 > set_def_fwd_config(); > if (nb_lcores =3D=3D 0) > diff --git a/examples/exception_path/main.c > b/examples/exception_path/main.c index 3f8b1fb..692383b 100644 > --- a/examples/exception_path/main.c > +++ b/examples/exception_path/main.c > @@ -546,9 +546,7 @@ main(int argc, char** argv) > /* Get number of ports found in scan */ > nb_sys_ports =3D rte_eth_dev_count(); > if (nb_sys_ports =3D=3D 0) > - FATAL_ERROR("No supported Ethernet devices found - check that " > - "CONFIG_RTE_LIBRTE_IGB_PMD=3Dy and/or " > - "CONFIG_RTE_LIBRTE_IXGBE_PMD=3Dy in the config file"); > + FATAL_ERROR("No supported Ethernet devices found"); > /* Find highest port set in portmask */ > for (high_port =3D (sizeof(ports_mask) * 8) - 1; > (high_port !=3D 0) && !(ports_mask & (1 << high_port)); diff --git > a/examples/kni/main.c b/examples/kni/main.c index 1344a87..370ae1c 100644 > --- a/examples/kni/main.c > +++ b/examples/kni/main.c > @@ -881,9 +881,7 @@ main(int argc, char** argv) > /* Get number of ports found in scan */ > nb_sys_ports =3D rte_eth_dev_count(); > if (nb_sys_ports =3D=3D 0) > - rte_exit(EXIT_FAILURE, "No supported Ethernet devices found - " > - "check that CONFIG_RTE_LIBRTE_IGB_PMD=3Dy and/or " > - "CONFIG_RTE_LIBRTE_IXGBE_PMD=3Dy in the config file\n"); > + rte_exit(EXIT_FAILURE, "No supported Ethernet devices found\n"); >=20 > /* Check if the configured port ID is valid */ > for (i =3D 0; i < RTE_MAX_ETHPORTS; i++) > -- > 2.1.3