From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E1C7E6828 for ; Mon, 10 Nov 2014 05:58:26 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 09 Nov 2014 21:08:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,350,1413270000"; d="scan'208";a="619776374" Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86]) by fmsmga001.fm.intel.com with ESMTP; 09 Nov 2014 21:08:08 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 10 Nov 2014 13:08:08 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.62]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.3]) with mapi id 14.03.0195.001; Mon, 10 Nov 2014 13:08:06 +0800 From: "Zhang, Helin" To: "Xie, Huawei" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 2/2] lib/librte_pmd_i40e: add I40E_VFTA_IDX and I40E_VFTA_BIT macros for VFTA related operation Thread-Index: AQHP/JCrP2T5i6JTpEej4RaOh5n2U5xZTvnw Date: Mon, 10 Nov 2014 05:08:06 +0000 Message-ID: References: <1415587563-11512-1-git-send-email-huawei.xie@intel.com> <1415587563-11512-3-git-send-email-huawei.xie@intel.com> In-Reply-To: <1415587563-11512-3-git-send-email-huawei.xie@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/2] lib/librte_pmd_i40e: add I40E_VFTA_IDX and I40E_VFTA_BIT macros for VFTA related operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Nov 2014 04:58:27 -0000 Hi Huawei > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Huawei Xie > Sent: Monday, November 10, 2014 10:46 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 2/2] lib/librte_pmd_i40e: add I40E_VFTA_IDX= and > I40E_VFTA_BIT macros for VFTA related operation >=20 > Add two macros I40E_VFTA_IDX and I40E_VFTA_BIT for VFTA manipulation. > Add vlan_id check in vlan filter search and set function. >=20 > Signed-off-by: Huawei Xie > --- > lib/librte_pmd_i40e/i40e_ethdev.c | 17 ++++++++++------- > lib/librte_pmd_i40e/i40e_ethdev.h | 9 +++++++++ > 2 files changed, 19 insertions(+), 7 deletions(-) >=20 > diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c > b/lib/librte_pmd_i40e/i40e_ethdev.c > index c0cf3cf..245460f 100644 > --- a/lib/librte_pmd_i40e/i40e_ethdev.c > +++ b/lib/librte_pmd_i40e/i40e_ethdev.c > @@ -4033,8 +4033,11 @@ i40e_find_vlan_filter(struct i40e_vsi *vsi, { > uint32_t vid_idx, vid_bit; >=20 > - vid_idx =3D (uint32_t) ((vlan_id >> 5) & 0x7F); > - vid_bit =3D (uint32_t) (1 << (vlan_id & 0x1F)); > + if (vlan_id > ETH_VLAN_ID_MAX) > + return 0; > + > + vid_idx =3D I40E_VFTA_IDX(vlan_id); > + vid_bit =3D I40E_VFTA_BIT(vlan_id); >=20 > if (vsi->vfta[vid_idx] & vid_bit) > return 1; > @@ -4048,11 +4051,11 @@ i40e_set_vlan_filter(struct i40e_vsi *vsi, { > uint32_t vid_idx, vid_bit; >=20 > - /* VFTA is 32-bits size array, each element contains 32 vlan bits, Find= the > - * element first, then find the bits it belongs to > - */ > - vid_idx =3D (uint32_t) ((vlan_id >> 5 ) & 0x7F); > - vid_bit =3D (uint32_t) (1 << (vlan_id & 0x1F)); > + if (vlan_id > ETH_VLAN_ID_MAX) > + return; > + > + vid_idx =3D I40E_VFTA_IDX(vlan_id); > + vid_bit =3D I40E_VFTA_BIT(vlan_id); >=20 > if (on) > vsi->vfta[vid_idx] |=3D vid_bit; > diff --git a/lib/librte_pmd_i40e/i40e_ethdev.h > b/lib/librte_pmd_i40e/i40e_ethdev.h > index 96361c2..4f2c16a 100644 > --- a/lib/librte_pmd_i40e/i40e_ethdev.h > +++ b/lib/librte_pmd_i40e/i40e_ethdev.h > @@ -50,6 +50,15 @@ > #define I40E_DEFAULT_QP_NUM_FDIR 64 > #define I40E_UINT32_BIT_SIZE (CHAR_BIT * sizeof(uint32_t)) > #define I40E_VFTA_SIZE (4096 / I40E_UINT32_BIT_SIZE) > +/* > + * vlan_id is a 12 bit number. > + * The VFTA array is actually a 4096 bit array, 128 of 32bit elements. > + * 2^5 =3D 32. The val of lower 5 bits specifies the bit in the 32bit el= ement. > + * The higher 7 bit val specifies VFTA array index. > + */ > +#define I40E_VFTA_BIT(vlan_id) (1 << ((vlan_id) & 0x1F)) > +#define I40E_VFTA_IDX(vlan_id) ((vlan_id) >> 5) Why not define the 0x1f and 5 more meaningful in macros? Why define it in this header file? It seems that only used in i40e_ethdev.c= . > + > /* Default TC traffic in case DCB is not enabled */ > #define I40E_DEFAULT_TCMAP 0x1 >=20 > -- > 1.8.1.4 Regards, Helin