From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 853D36828 for ; Mon, 10 Nov 2014 05:59:21 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 09 Nov 2014 21:09:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,350,1413270000"; d="scan'208";a="605105473" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by orsmga001.jf.intel.com with ESMTP; 09 Nov 2014 21:09:03 -0800 Received: from pgsmsx102.gar.corp.intel.com (10.221.44.80) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 10 Nov 2014 13:08:48 +0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 10 Nov 2014 13:08:48 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.62]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.242]) with mapi id 14.03.0195.001; Mon, 10 Nov 2014 13:08:47 +0800 From: "Zhang, Helin" To: "Xie, Huawei" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 1/2] lib/librte_pmd_i40e: set vlan filter fix Thread-Index: AQHP/JCsgPWLX2DvqkSel8Yc5cjVuZxZT4Sw Date: Mon, 10 Nov 2014 05:08:47 +0000 Message-ID: References: <1415587563-11512-1-git-send-email-huawei.xie@intel.com> <1415587563-11512-2-git-send-email-huawei.xie@intel.com> In-Reply-To: <1415587563-11512-2-git-send-email-huawei.xie@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] lib/librte_pmd_i40e: set vlan filter fix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Nov 2014 04:59:23 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Huawei Xie > Sent: Monday, November 10, 2014 10:46 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 1/2] lib/librte_pmd_i40e: set vlan filter f= ix >=20 > ">> 5" rather than ">> 4" >=20 > Signed-off-by: Huawei Xie > --- > lib/librte_pmd_i40e/i40e_ethdev.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) >=20 > diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c > b/lib/librte_pmd_i40e/i40e_ethdev.c > index 5074262..c0cf3cf 100644 > --- a/lib/librte_pmd_i40e/i40e_ethdev.c > +++ b/lib/librte_pmd_i40e/i40e_ethdev.c > @@ -4048,14 +4048,11 @@ i40e_set_vlan_filter(struct i40e_vsi *vsi, { > uint32_t vid_idx, vid_bit; >=20 > -#define UINT32_BIT_MASK 0x1F > -#define VALID_VLAN_BIT_MASK 0xFFF > /* VFTA is 32-bits size array, each element contains 32 vlan bits, Find= the > * element first, then find the bits it belongs to > */ > - vid_idx =3D (uint32_t) ((vlan_id & VALID_VLAN_BIT_MASK) >> > - sizeof(uint32_t)); > - vid_bit =3D (uint32_t) (1 << (vlan_id & UINT32_BIT_MASK)); > + vid_idx =3D (uint32_t) ((vlan_id >> 5 ) & 0x7F); > + vid_bit =3D (uint32_t) (1 << (vlan_id & 0x1F)); I don't understand why remove macros and use numeric instead? >=20 > if (on) > vsi->vfta[vid_idx] |=3D vid_bit; > -- > 1.8.1.4 Regards, Helin