From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A621A7E9D for ; Wed, 12 Nov 2014 15:13:29 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 12 Nov 2014 06:22:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,369,1413270000"; d="scan'208";a="621210019" Received: from kmsmsx152.gar.corp.intel.com ([172.21.73.87]) by fmsmga001.fm.intel.com with ESMTP; 12 Nov 2014 06:22:40 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by KMSMSX152.gar.corp.intel.com (172.21.73.87) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 12 Nov 2014 22:22:39 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.62]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.130]) with mapi id 14.03.0195.001; Wed, 12 Nov 2014 22:22:38 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v5 2/5] ethdev: add enum type and relevant structures for hash filter control Thread-Index: AQHP9zv1q1ow4Cmu+UqdYuQikZttDJxbBYHAgABtNgCAANZFIP//+RSAgADW3+A= Date: Wed, 12 Nov 2014 14:22:37 +0000 Message-ID: References: <1413180766-12211-1-git-send-email-helin.zhang@intel.com> <1639194.lo0Mfvn8hI@xps13> <7782514.0Lq6O9Rqxb@xps13> In-Reply-To: <7782514.0Lq6O9Rqxb@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v5 2/5] ethdev: add enum type and relevant structures for hash filter control X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Nov 2014 14:13:30 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, November 12, 2014 5:31 PM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 2/5] ethdev: add enum type and relevant > structures for hash filter control >=20 > 2014-11-12 05:52, Zhang, Helin: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > Actually you use ETH_FLOW_TYPE_IPV4 for ixgbe and > > > ETH_FLOW_TYPE_FRAG_IPV4 or ETH_FLOW_TYPE_NONFRAG_IPV4_* for > i40e. > > > It's not consistent and clearly shows that you stick to the hardware > definitions. > > > > > > Something really generic could be a set of flags like this: > > > IPV4 > > > IPV6 > > > NONFRAG > > > UDP > > > TCP > > > SCTP > > > > Good conclusion! We could think of it in a new patch set. > > I don't want to put everything into this patch. :) >=20 > If you agree flags must be used, the old defines must be removed. > So no need to rename the defines. > I think you should directly change to flags (in this patchset or another)= . I will keep it as it is in this patch for configuring hash functions. But I= really agree with your idea of using flags instead. I will rework it in another patch set and send out a RFC to see if there is= any objections. For this patch set, I will focus on feature itself. >=20 > Thanks > -- > Thomas Regards, Helin