From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A97EE18F for ; Tue, 2 Dec 2014 01:36:17 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 01 Dec 2014 16:36:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="423783867" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by FMSMGA003.fm.intel.com with ESMTP; 01 Dec 2014 16:26:05 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 2 Dec 2014 08:35:47 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.182]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.86]) with mapi id 14.03.0195.001; Tue, 2 Dec 2014 08:35:45 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] i40e: bug fix of compile error Thread-Index: AQHQDVfiE9AilI4l+EGUYz8sc8YbiJx7dHVQ Date: Tue, 2 Dec 2014 00:35:45 +0000 Message-ID: References: <1417419227-21465-1-git-send-email-helin.zhang@intel.com> <2036571.ijmOSAQnXA@xps13> In-Reply-To: <2036571.ijmOSAQnXA@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] i40e: bug fix of compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Dec 2014 00:36:18 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, December 1, 2014 7:13 PM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] i40e: bug fix of compile error >=20 > 2014-12-01 15:33, Helin Zhang: > > The compile error will occur as below when set > 'RTE_LIBRTE_I40E_16BYTE_RX_DESC=3Dy'. > > The changes is just to fix it. > > > > lib/librte_pmd_i40e/i40e_rxtx.c: In function i40e_rxd_build_fdir: > > lib/librte_pmd_i40e/i40e_rxtx.c:431:28: error: volatile union > > has no member named fd > > lib/librte_pmd_i40e/i40e_rxtx.c:427:19: error: unused variable flexbl > > [-Werror=3Dunused-variable] > > lib/librte_pmd_i40e/i40e_rxtx.c:427:11: error: unused variable flexbh > > [-Werror=3Dunused-variable] >=20 > It would be nice to reference the commit which introduced the error and e= xplain > it a bit. >=20 > > - rte_le_to_cpu_32(rxdp->wb.qword3.hi_dword.flex_bytes_hi); > > + rte_le_to_cpu_32( > > + rxdp->wb.qword3.hi_dword.flex_bytes_hi); > [...] > > - rte_le_to_cpu_32(rxdp->wb.qword3.lo_dword.flex_bytes_lo); > > + rte_le_to_cpu_32( > > + rxdp->wb.qword3.lo_dword.flex_bytes_lo); >=20 > Why are you wrapping these lines (with wrong indentation)? > It makes the fix confuse. Sorry, it is a code style fix, as the length of the line should not be more= than 80. Do I need to split the patch or add more commit logs? >=20 > -- > Thomas Regards, Helin