From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E6B446A8B for ; Wed, 10 Dec 2014 14:51:02 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 10 Dec 2014 05:51:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,552,1413270000"; d="scan'208";a="645453107" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by fmsmga002.fm.intel.com with ESMTP; 10 Dec 2014 05:51:00 -0800 Received: from pgsmsx102.gar.corp.intel.com (10.221.44.80) by PGSMSX107.gar.corp.intel.com (10.221.44.105) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 10 Dec 2014 21:50:59 +0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 10 Dec 2014 21:50:59 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.182]) by shsmsx102.ccr.corp.intel.com ([169.254.2.216]) with mapi id 14.03.0195.001; Wed, 10 Dec 2014 21:50:57 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v4] mbuf: fix of enabling all newly added RX error flags Thread-Index: AQHQFFzOtE3RTEW+NEmbeyO057Pa/JyI1wTQ Date: Wed, 10 Dec 2014 13:50:57 +0000 Message-ID: References: <1417829617-7185-1-git-send-email-helin.zhang@intel.com> <1418201706-32162-1-git-send-email-helin.zhang@intel.com> <2233989.0bm00NiAWz@xps13> In-Reply-To: <2233989.0bm00NiAWz@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4] mbuf: fix of enabling all newly added RX error flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Dec 2014 13:51:03 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, December 10, 2014 5:35 PM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] mbuf: fix of enabling all newly added = RX > error flags >=20 > 2014-12-10 16:55, Helin Zhang: > > Before redefining mbuf structure, there was lack of free bits in 'ol_fl= ags' > > (32 bits in total) for new RX or TX flags. So it tried to reuse > > existant bits as most as possible, or even assigning 0 to some of bit > > flags. After new mbuf structure defined, there are quite a lot of free > > bits. So those newly added bit flags should be assigned with correct > > and valid bit values, and getting their names should be enabled as > > well. Note that 'RECIP' should be removed, as nowhere uses it. > > 'PKT_RX_ERR' is defined to replace all other error bit flags, e.g. MAC = error, > Oversize error, header buffer overflow error. > > > > Signed-off-by: Helin Zhang > > --- > > lib/librte_mbuf/rte_mbuf.c | 7 ++----- > > lib/librte_mbuf/rte_mbuf.h | 9 +++------ > > lib/librte_pmd_i40e/i40e_rxtx.c | 37 > > ++++++++++++++++++++----------------- > > 3 files changed, 25 insertions(+), 28 deletions(-) > > > > v2 changes: > > * Removed error flag of 'ECIPE' processing only in both i40e PMD and mb= uf. > All > > other error flags were added back. > > * Assigned error flags with correct and valid values, as their previous= values > > were invalid. > > * Enabled getting all error flag names. > > > > v3 changes: > > * 'PKT_RX_ERR' is defined to replace error bit flags of MAC error, Over= size > > error, header buffer overflow error. > > * Removed assigning values to PKT_TX_* bit flags, as it has already bee= n > done > > in another packet set. > > > > v4 changes: > > * Renamed 'PKT_RX_EIP_CKSUM_BAD' to 'PKT_RX_OUTER_IP_CKSUM_BAD'. > > * Fixed the bug of checking error bits of 'Descriptor oversize' and > > 'Header buffer oversize'. > > * Added debug logs for each RX error. > [...] > > --- a/lib/librte_mbuf/rte_mbuf.h > > +++ b/lib/librte_mbuf/rte_mbuf.h > > @@ -83,12 +83,7 @@ extern "C" { > > #define PKT_RX_RSS_HASH (1ULL << 1) /**< RX packet with RSS > hash result. */ > > #define PKT_RX_FDIR (1ULL << 2) /**< RX packet with FDIR > match indicate. */ > > #define PKT_RX_L4_CKSUM_BAD (1ULL << 3) /**< L4 cksum of RX pkt. > is > > not OK. */ -#define PKT_RX_IP_CKSUM_BAD (1ULL << 4) /**< IP cksum of > > RX pkt. is not OK. */ -#define PKT_RX_EIP_CKSUM_BAD (0ULL << 0) /**< > External IP header checksum error. */ > > -#define PKT_RX_OVERSIZE (0ULL << 0) /**< Num of desc of an RX > pkt oversize. */ > > -#define PKT_RX_HBUF_OVERFLOW (0ULL << 0) /**< Header buffer > overflow. */ > > -#define PKT_RX_RECIP_ERR (0ULL << 0) /**< Hardware processing > error. */ > > -#define PKT_RX_MAC_ERR (0ULL << 0) /**< MAC error. */ > > +#define PKT_RX_IP_CKSUM_BAD (1ULL << 4) /**< IP (or inner IP) > > +header checksum error. */ >=20 > It can be also an outer IP header in case the device don't support tunnel= ing or is > not configured to detect it. For non-tunneling case, no outer/inner at all, it just has the IP header. T= he bit flag indicates the IP header checksum error. For tunneling case, this bit flag indicates the inner IP header checksum er= ror, another one for outer IP header checksum error. So I don't think this bit can be treated as outer. Regards, Helin > -- > Thomas >=20 > > #define PKT_RX_IPV4_HDR (1ULL << 5) /**< RX packet with IPv4 > header. */ > > #define PKT_RX_IPV4_HDR_EXT (1ULL << 6) /**< RX packet with > extended IPv4 header. */ > > #define PKT_RX_IPV6_HDR (1ULL << 7) /**< RX packet with IPv6 > header. */ > > @@ -99,6 +94,8 @@ extern "C" { > > #define PKT_RX_TUNNEL_IPV6_HDR (1ULL << 12) /**< RX tunnel packet > with IPv6 header. */ > > #define PKT_RX_FDIR_ID (1ULL << 13) /**< FD id reported if FDIR > match. */ > > #define PKT_RX_FDIR_FLX (1ULL << 14) /**< Flexible bytes reported > if FDIR match. */ > > +#define PKT_RX_OUTER_IP_CKSUM_BAD (1ULL << 15) /**< Outer IP > header checksum error. */ > > +#define PKT_RX_ERR (1ULL << 16) /**< Other errors, e.g. > MAC error. */ > > /* add new RX flags here */ > > > > /* add new TX flags here */