From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A82F419F5 for ; Wed, 24 Dec 2014 04:53:39 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP; 23 Dec 2014 19:51:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="432828952" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by FMSMGA003.fm.intel.com with ESMTP; 23 Dec 2014 19:42:05 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by KMSMSX153.gar.corp.intel.com (172.21.73.88) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 24 Dec 2014 11:53:34 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.182]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.110]) with mapi id 14.03.0195.001; Wed, 24 Dec 2014 11:53:33 +0800 From: "Zhang, Helin" To: "Ouyang, Changchun" Thread-Topic: [dpdk-dev] [PATCH v2 1/6] ixgbe: Code cleanup Thread-Index: AQHQHyVS2jdLT8OVMUqRGqDQCceeBJyeDu+Q//9+RQCAAIlEYP//fpKAgACG0wA= Date: Wed, 24 Dec 2014 03:53:33 +0000 Message-ID: References: <1418612225-6095-1-git-send-email-changchun.ouyang@intel.com> <1419389808-9559-1-git-send-email-changchun.ouyang@intel.com> <1419389808-9559-2-git-send-email-changchun.ouyang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 1/6] ixgbe: Code cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Dec 2014 03:53:40 -0000 > -----Original Message----- > From: Ouyang, Changchun > Sent: Wednesday, December 24, 2014 11:50 AM > To: Zhang, Helin > Cc: dev@dpdk.org; Ouyang, Changchun > Subject: RE: [dpdk-dev] [PATCH v2 1/6] ixgbe: Code cleanup >=20 > Hi Helin, >=20 > > -----Original Message----- > > From: Zhang, Helin > > Sent: Wednesday, December 24, 2014 11:41 AM > > To: Ouyang, Changchun > > Cc: dev@dpdk.org > > Subject: RE: [dpdk-dev] [PATCH v2 1/6] ixgbe: Code cleanup > > > > Hi Changchun > > > > > -----Original Message----- > > > From: Ouyang, Changchun > > > Sent: Wednesday, December 24, 2014 11:22 AM > > > To: Zhang, Helin; dev@dpdk.org > > > Cc: Ouyang, Changchun > > > Subject: RE: [dpdk-dev] [PATCH v2 1/6] ixgbe: Code cleanup > > > > > > Hi Helin, > > > > > > > -----Original Message----- > > > > From: Zhang, Helin > > > > Sent: Wednesday, December 24, 2014 11:08 AM > > > > To: Ouyang, Changchun; dev@dpdk.org > > > > Subject: RE: [dpdk-dev] [PATCH v2 1/6] ixgbe: Code cleanup > > > > > > > > Is header split really supported in ixgbe? I guess not. If not, > > > > this code changes are not needed at all. > > > > > > > > > > I don't try to modify any logic here, as you know vf rss don't have > > > nothing to do with header split. > > But you modified code for header split. Have you validated it? > > > > > You mean " guess not ", can you 'make sure of it' rather than 'guess' > > > if you want to remove those codes? > > I did not see anywhere can enable ixgbe header split. It is your turn > > to make sure if your code changes are needed and correct. I don't want > > to remove any code, just want to know if your code have been validated = for > header split. >=20 > Yes, I make sure the code change is correct, and already validate the cod= e > change on my platform, besides that, we also have validation team to do > further validation. any other concern then? I still don't know how to enable header split for ixgbe. Any answer from yo= u? Regards, Helin >=20 > Thanks > Changchun