Re: [dpdk-dev] [PATCH RFC 0/7] unification of flow types and RSS offload types

["Zhang, Helin" <helin.zhang@intel.com>]

Hello

Does anybody has any more review comments or ideas for this? I will send out the formal patch soon. Thanks a lot!

Regards,
Helin

> -----Original Message-----
> From: Zhang, Helin
> Sent: Friday, December 19, 2014 3:27 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing; Liu, Jijiang; Chen, Jing D; Cao, Waterman; Richardson, Bruce;
> Patel, Rashmin N; Zhang, Helin
> Subject: [PATCH RFC 0/7] unification of flow types and RSS offload types
> 
> It unifies the flow types and RSS offload types for all PMDs.
> Previously flow types are defined actually for i40e, and there has different RSS
> offloads tyeps for 1/10G and 40G seperately.
> This is not so convenient for application development, and not good for adding
> new PMDs. In addition, it enables new RSS offloads of 'tcp' and 'all' in testpmd.
> 
> Helin Zhang (7):
>   app/test-pmd: code style fix
>   ethdev: code style fix
>   i40e: code style fix
>   ethdev: fix of calculating the size of flow type mask array
>   ethdev: unification of flow types
>   ethdev: unification of RSS offload types
>   app/testpmd: support new rss offloads
> 
>  app/test-pipeline/init.c                |   2 +-
>  app/test-pmd/cmdline.c                  | 104 ++++++++++++++--------
>  app/test-pmd/config.c                   | 132
> +++++++++++++++++++---------
>  examples/distributor/main.c             |   9 +-
>  examples/ip_pipeline/init.c             |   2 +-
>  examples/l3fwd-acl/main.c               |   7 +-
>  lib/librte_ether/rte_eth_ctrl.h         |  91 +++++++++++---------
>  lib/librte_ether/rte_ethdev.h           | 147 +++++++++++++-------------------
>  lib/librte_pmd_e1000/e1000_ethdev.h     |  11 +++
>  lib/librte_pmd_e1000/igb_ethdev.c       |   1 +
>  lib/librte_pmd_e1000/igb_rxtx.c         |  27 ++----
>  lib/librte_pmd_i40e/i40e_ethdev.c       | 126 ++++++++++++++-------------
>  lib/librte_pmd_i40e/i40e_ethdev.h       |  50 +++++------
>  lib/librte_pmd_i40e/i40e_ethdev_vf.c    |   1 +
>  lib/librte_pmd_i40e/i40e_fdir.c         |  91 ++++++++++----------
>  lib/librte_pmd_ixgbe/ixgbe_ethdev.c     |   1 +
>  lib/librte_pmd_ixgbe/ixgbe_ethdev.h     |  11 +++
>  lib/librte_pmd_ixgbe/ixgbe_rxtx.c       |  27 ++----
>  lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c |   1 +
>  lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h |   6 ++
>  lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c   |  10 +--
>  21 files changed, 470 insertions(+), 387 deletions(-)
> 
> --
> 1.9.3