DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] i40e: workaround for XL710 performance
Date: Mon, 12 Jan 2015 07:57:10 +0000
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7DE2F9@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F8B6F609@SHSMSX104.ccr.corp.intel.com>

Thank you, Jingjing!

Regards,
Helin

> -----Original Message-----
> From: Wu, Jingjing
> Sent: Monday, January 12, 2015 3:34 PM
> To: Zhang, Helin; dev@dpdk.org
> Cc: nhorman@tuxdriver.com; Xu, Qian Q; Cao, Waterman; Lu, Patrick; Liu,
> Jijiang
> Subject: RE: [PATCH v2] i40e: workaround for XL710 performance
> 
> 
> 
> > -----Original Message-----
> > From: Zhang, Helin
> > Sent: Monday, December 29, 2014 9:41 AM
> > To: dev@dpdk.org
> > Cc: nhorman@tuxdriver.com; Xu, Qian Q; Cao, Waterman; Lu, Patrick;
> > Liu, Jijiang; Wu, Jingjing; Zhang, Helin
> > Subject: [PATCH v2] i40e: workaround for XL710 performance
> >
> > On XL710, performance number is far from the expectation on recent
> > firmware versions, if promiscuous mode is disabled, or promiscuous
> > mode is enabled and port MAC address is equal to the packet
> > destination MAC address. The fix for this issue may not be integrated
> > in the following firmware version. So the workaround in software
> > driver is needed. For XL710, it needs to modify the initial values of
> > 3 internal only registers, which are the same as X710.
> > Note that the values for X710 and XL710 registers could be different,
> > and the workaround can be removed when it is fixed in firmware in the future.
> >
> > Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> > ---
> >  lib/librte_pmd_i40e/i40e_ethdev.c | 44 ++++++++++++++++++++++++++---
> > ----------
> >  1 file changed, 30 insertions(+), 14 deletions(-)
> >
> > v2 changes:
> > * Supported modifying the address of 0x269FBC of XL710 during
> >   initialization, to fix the minor performance gap to expectation.
> >   That means XL710 can meet the performance expectation with this
> >   workaround.
> >
> > diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c
> > b/lib/librte_pmd_i40e/i40e_ethdev.c
> > index b47a3d2..8982920 100644
> > --- a/lib/librte_pmd_i40e/i40e_ethdev.c
> > +++ b/lib/librte_pmd_i40e/i40e_ethdev.c
> > @@ -5327,38 +5327,54 @@ i40e_debug_read_register(struct i40e_hw *hw,
> > uint32_t addr, uint64_t *val)
> >
> >  /*
> >   * On X710, performance number is far from the expectation on recent
> > firmware
> > - * versions. The fix for this issue may not be integrated in the
> > following
> > + * versions; on XL710, performance number is also far from the
> > + expectation on
> > + * recent firmware versions, if promiscuous mode is disabled, or
> > + promiscuous
> > + * mode is enabled and port MAC address is equal to the packet
> > + destination MAC
> > + * address. The fix for this issue may not be integrated in the
> > + following
> >   * firmware version. So the workaround in software driver is needed.
> > It needs
> > - * to modify the initial values of 3 internal only registers. Note
> > that the
> > + * to modify the initial values of 3 internal only registers for both
> > + X710 and
> > + * XL710. Note that the values for X710 or XL710 could be different,
> > + and the
> >   * workaround can be removed when it is fixed in firmware in the future.
> >   */
> > -static void
> > -i40e_configure_registers(struct i40e_hw *hw) -{
> > +
> > +/* For both X710 and XL710 */
> > +#define I40E_GL_SWR_PRI_JOIN_MAP_0_VALUE 0x10000200
> >  #define I40E_GL_SWR_PRI_JOIN_MAP_0       0x26CE00
> > +
> > +#define I40E_GL_SWR_PRI_JOIN_MAP_2_VALUE 0x011f0200
> >  #define I40E_GL_SWR_PRI_JOIN_MAP_2       0x26CE08
> > +
> > +/* For X710 */
> > +#define I40E_GL_SWR_PM_UP_THR_EF_VALUE   0x03030303
> > +/* For XL710 */
> > +#define I40E_GL_SWR_PM_UP_THR_SF_VALUE   0x06060606
> >  #define I40E_GL_SWR_PM_UP_THR            0x269FBC
> > -#define I40E_GL_SWR_PRI_JOIN_MAP_0_VALUE 0x10000200 -#define
> > I40E_GL_SWR_PRI_JOIN_MAP_2_VALUE 0x011f0200
> > -#define I40E_GL_SWR_PM_UP_THR_VALUE      0x03030303
> >
> > -	static const struct {
> > +static void
> > +i40e_configure_registers(struct i40e_hw *hw) {
> > +	static struct {
> >  		uint32_t addr;
> >  		uint64_t val;
> >  	} reg_table[] = {
> >  		{I40E_GL_SWR_PRI_JOIN_MAP_0,
> > I40E_GL_SWR_PRI_JOIN_MAP_0_VALUE},
> >  		{I40E_GL_SWR_PRI_JOIN_MAP_2,
> > I40E_GL_SWR_PRI_JOIN_MAP_2_VALUE},
> > -		{I40E_GL_SWR_PM_UP_THR,
> > I40E_GL_SWR_PM_UP_THR_VALUE},
> > +		{I40E_GL_SWR_PM_UP_THR, 0}, /* Compute value
> > dynamically */
> >  	};
> >  	uint64_t reg;
> >  	uint32_t i;
> >  	int ret;
> >
> > -	/* Below fix is for X710 only */
> > -	if (i40e_is_40G_device(hw->device_id))
> > -		return;
> > -
> >  	for (i = 0; i < RTE_DIM(reg_table); i++) {
> > +		if (reg_table[i].addr == I40E_GL_SWR_PM_UP_THR) {
> > +			if (i40e_is_40G_device(hw->device_id)) /* For XL710
> > */
> > +				reg_table[i].val =
> > +
> > 	I40E_GL_SWR_PM_UP_THR_SF_VALUE;
> > +			else /* For X710 */
> > +				reg_table[i].val =
> > +
> > 	I40E_GL_SWR_PM_UP_THR_EF_VALUE;
> > +		}
> > +
> >  		ret = i40e_debug_read_register(hw, reg_table[i].addr, &reg);
> >  		if (ret < 0) {
> >  			PMD_DRV_LOG(ERR, "Failed to read from 0x%"PRIx32,
> > --
> > 1.9.3
> 
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>

  reply	other threads:[~2015-01-12  7:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-24  7:14 [dpdk-dev] [PATCH] " Helin Zhang
2014-12-24 14:55 ` Neil Horman
2014-12-25  0:20   ` Zhang, Helin
2014-12-26 14:28     ` Neil Horman
2014-12-28 13:22       ` Zhang, Helin
2014-12-29  1:41 ` [dpdk-dev] [PATCH v2] " Helin Zhang
2015-01-12  7:33   ` Wu, Jingjing
2015-01-12  7:57     ` Zhang, Helin [this message]
2015-01-16  5:54   ` Zhang, Helin
2015-02-10  9:06   ` Xu, Qian Q

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A7DE2F9@SHSMSX104.ccr.corp.intel.com \
    --to=helin.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git