From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D49F35A1F for ; Wed, 21 Jan 2015 01:13:59 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 20 Jan 2015 16:07:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,438,1418112000"; d="scan'208";a="653993022" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by fmsmga001.fm.intel.com with ESMTP; 20 Jan 2015 16:13:36 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 21 Jan 2015 08:13:35 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.231]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.92]) with mapi id 14.03.0195.001; Wed, 21 Jan 2015 08:13:33 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v8 3/4] i40e: support of controlling hash functions Thread-Index: AQHQNIddreyrne8OmU6CnvUS5U4J5JzJtQMw Date: Wed, 21 Jan 2015 00:13:32 +0000 Message-ID: References: <1417176852-12345-1-git-send-email-helin.zhang@intel.com> <1417486760-24459-1-git-send-email-helin.zhang@intel.com> <1417486760-24459-4-git-send-email-helin.zhang@intel.com> <3554949.i7emeOiECJ@xps13> In-Reply-To: <3554949.i7emeOiECJ@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v8 3/4] i40e: support of controlling hash functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2015 00:14:00 -0000 Hi Thomas Sure, I will do it ASAP! Thank you for the helps! Regards, Helin > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, January 20, 2015 3:54 PM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 3/4] i40e: support of controlling hash > functions >=20 > Hi Helin, >=20 > 2014-12-02 10:19, Helin Zhang: > > Hash filter control has been implemented for i40e. It includes > > getting/setting, > > - global hash configurations (hash function type, and symmetric > > hash enable per flow type) > > - symmetric hash enable per port > > > > Signed-off-by: Helin Zhang > > --- > > lib/librte_ether/rte_eth_ctrl.h | 63 ++++++++ > > lib/librte_pmd_i40e/i40e_ethdev.c | 294 > > +++++++++++++++++++++++++++++++++++++- > > 2 files changed, 355 insertions(+), 2 deletions(-) >=20 > Please, could you split ethdev and i40e parts while keeping Konstantin's = ack? >=20 > [...] > > + * Each bit in valid_bit_mask[] indicates if the coresponding bit in >=20 > Typo: corresponding >=20 > [...] > > + /** Bit mask indicates if the coresponding bit is valid */ >=20 > Same typo >=20 > [...] > > + /** Details of hash filter infomation */ >=20 > Typo: information >=20 > > + union { > > + /* For RTE_ETH_HASH_FILTER_SYM_HASH_ENA_PER_PORT */ > > + uint8_t enable; > > + /* Global configurations of hash filter */ > > + struct rte_eth_hash_global_conf global_conf; > > + } info; >=20 > Why these comments are not doxygen'ed? >=20 > Sorry for nitpicking, that's the last review pass ;) > -- > Thomas