From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E396D37AF for ; Tue, 3 Feb 2015 03:35:31 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 02 Feb 2015 18:35:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,510,1418112000"; d="scan'208";a="646454926" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by orsmga001.jf.intel.com with ESMTP; 02 Feb 2015 18:35:27 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 3 Feb 2015 10:35:25 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.161]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.129]) with mapi id 14.03.0195.001; Tue, 3 Feb 2015 10:35:25 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v9 5/5] app/testpmd: add commands to support hash functions Thread-Index: AQHQPvicqiVgYZ9CrEiSht8paTckRJzeNd+A Date: Tue, 3 Feb 2015 02:35:24 +0000 Message-ID: References: <1417486760-24459-1-git-send-email-helin.zhang@intel.com> <1421912219-1946-1-git-send-email-helin.zhang@intel.com> <1421912219-1946-6-git-send-email-helin.zhang@intel.com> <5028514.8nkR6oWFO2@xps13> In-Reply-To: <5028514.8nkR6oWFO2@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v9 5/5] app/testpmd: add commands to support hash functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2015 02:35:32 -0000 Hi Thomas Yes, I agree with you. Documentation is needed. I will update it soon later= together with others I need to update. Thanks for your reminder! Regards, Helin > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, February 2, 2015 10:57 PM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 5/5] app/testpmd: add commands to suppo= rt > hash functions >=20 > 2015-01-22 15:36, Helin Zhang: > > To demonstrate the hash filter control, commands are added. > > They are, > > - get_sym_hash_ena_per_port > > - set_sym_hash_ena_per_port > > - get_hash_global_config > > - set_hash_global_config > > > > Signed-off-by: Helin Zhang > > --- > > app/test-pmd/cmdline.c | 333 > > +++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 333 insertions(+) >=20 > The new testpmd functions should be documented in > doc/guides/testpmd_app_ug/testpmd_funcs.rst. > The patch won't be blocked waiting for documentation because it is an old > patchset and the doc requirement is newer. > Please, don't forget to submit a doc patch. > -- > Thomas