From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 297037F6D for ; Fri, 13 Feb 2015 01:36:28 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 12 Feb 2015 16:36:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,567,1418112000"; d="scan'208";a="665716465" Received: from kmsmsx152.gar.corp.intel.com ([172.21.73.87]) by fmsmga001.fm.intel.com with ESMTP; 12 Feb 2015 16:36:25 -0800 Received: from kmsmsx154.gar.corp.intel.com (172.21.73.14) by KMSMSX152.gar.corp.intel.com (172.21.73.87) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 13 Feb 2015 08:36:24 +0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by KMSMSX154.gar.corp.intel.com (172.21.73.14) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 13 Feb 2015 08:36:24 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.161]) by shsmsx102.ccr.corp.intel.com ([169.254.2.62]) with mapi id 14.03.0195.001; Fri, 13 Feb 2015 08:36:23 +0800 From: "Zhang, Helin" To: "Doherty, Declan" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 06/17] bond: support of unified packet type Thread-Index: AQHQRgswpetHj5RipE6uDsW+9+FtoZztveEQ Date: Fri, 13 Feb 2015 00:36:22 +0000 Message-ID: References: <1421637666-16872-1-git-send-email-helin.zhang@intel.com> <1422501365-12643-1-git-send-email-helin.zhang@intel.com> <1422501365-12643-7-git-send-email-helin.zhang@intel.com> <54DB6EB7.6000207@intel.com> In-Reply-To: <54DB6EB7.6000207@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 06/17] bond: support of unified packet type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Feb 2015 00:36:28 -0000 Hi Declan Yes, I got it. I already have v2 patch of it which has no changes for bond = anymore. Thanks! Regards, Helin > -----Original Message----- > From: Doherty, Declan > Sent: Wednesday, February 11, 2015 11:01 PM > To: Zhang, Helin; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 06/17] bond: support of unified packet typ= e >=20 > On 29/01/15 03:15, Helin Zhang wrote: > > To unify packet types among all PMDs, bit masks of packet type for > > ol_flags are replaced by unified packet type. > > > > Signed-off-by: Helin Zhang > > --- > > lib/librte_pmd_bond/rte_eth_bond_pmd.c | 9 ++++----- > > 1 file changed, 4 insertions(+), 5 deletions(-) > > > > diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c > > b/lib/librte_pmd_bond/rte_eth_bond_pmd.c > > index 8b80297..acd8e77 100644 > > --- a/lib/librte_pmd_bond/rte_eth_bond_pmd.c > > +++ b/lib/librte_pmd_bond/rte_eth_bond_pmd.c > > @@ -319,12 +319,11 @@ xmit_l23_hash(const struct rte_mbuf *buf, > > uint8_t slave_count) > > > > hash =3D ether_hash(eth_hdr); > > > > - if (buf->ol_flags & PKT_RX_IPV4_HDR) { > > + if (RTE_ETH_IS_IPV4_HDR(buf->packet_type)) { > > struct ipv4_hdr *ipv4_hdr =3D (struct ipv4_hdr *) > > ((char *)(eth_hdr + 1) + vlan_offset); > > l3hash =3D ipv4_hash(ipv4_hdr); > > - > > - } else if (buf->ol_flags & PKT_RX_IPV6_HDR) { > > + } else if (RTE_ETH_IS_IPV6_HDR(buf->packet_type)) { > > struct ipv6_hdr *ipv6_hdr =3D (struct ipv6_hdr *) > > ((char *)(eth_hdr + 1) + vlan_offset); > > l3hash =3D ipv6_hash(ipv6_hdr); > > @@ -346,7 +345,7 @@ xmit_l34_hash(const struct rte_mbuf *buf, uint8_t > slave_count) > > struct tcp_hdr *tcp_hdr =3D NULL; > > uint32_t hash, l3hash =3D 0, l4hash =3D 0; > > > > - if (buf->ol_flags & PKT_RX_IPV4_HDR) { > > + if (RTE_ETH_IS_IPV4_HDR(buf->packet_type)) { > > struct ipv4_hdr *ipv4_hdr =3D (struct ipv4_hdr *) > > ((char *)(eth_hdr + 1) + vlan_offset); > > size_t ip_hdr_offset; > > @@ -365,7 +364,7 @@ xmit_l34_hash(const struct rte_mbuf *buf, uint8_t > slave_count) > > ip_hdr_offset); > > l4hash =3D HASH_L4_PORTS(udp_hdr); > > } > > - } else if (buf->ol_flags & PKT_RX_IPV6_HDR) { > > + } else if (RTE_ETH_IS_IPV6_HDR(buf->packet_type)) { > > struct ipv6_hdr *ipv6_hdr =3D (struct ipv6_hdr *) > > ((char *)(eth_hdr + 1) + vlan_offset); > > l3hash =3D ipv6_hash(ipv6_hdr); > > >=20 > Hey Helin, > this patch should no longer be necessary as commit # > bffc9b35e3acd70895b73616c850d8d37fe5732e removed all references to the > ol_flags in the link bonding code. >=20 > Declan