DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] eal: remove unnecessary #ifdef CONFIG_BQL
@ 2015-03-13 19:21 Alex Gartrell
  2015-03-23 11:27 ` Thomas Monjalon
  2015-03-24  1:03 ` Zhang, Helin
  0 siblings, 2 replies; 3+ messages in thread
From: Alex Gartrell @ 2015-03-13 19:21 UTC (permalink / raw)
  To: dev; +Cc: kernel-team

I couldn't figure out why this #ifdef existed so I looked around upstream
and it's not there.  It seems to build just fine without it.

Signed-off-by: Alex Gartrell <agartrell@fb.com>
---
 lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
index a582f52..d58e1f3 100644
--- a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
+++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
@@ -472,12 +472,10 @@ static inline u16 igb_desc_unused(const struct igb_ring *ring)
 	return ((ntc > ntu) ? 0 : ring->count) + ntc - ntu - 1;
 }
 
-#ifdef CONFIG_BQL
 static inline struct netdev_queue *txring_txq(const struct igb_ring *tx_ring)
 {
 	return netdev_get_tx_queue(tx_ring->netdev, tx_ring->queue_index);
 }
-#endif /* CONFIG_BQL */
 
 // #ifdef EXT_THERMAL_SENSOR_SUPPORT
 // #ifdef IGB_PROCFS
-- 
Alex Gartrell <agartrell@fb.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] eal: remove unnecessary #ifdef CONFIG_BQL
  2015-03-13 19:21 [dpdk-dev] [PATCH] eal: remove unnecessary #ifdef CONFIG_BQL Alex Gartrell
@ 2015-03-23 11:27 ` Thomas Monjalon
  2015-03-24  1:03 ` Zhang, Helin
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-03-23 11:27 UTC (permalink / raw)
  To: helin.zhang; +Cc: dev, kernel-team

Helin, any comment about this trivial patch?

2015-03-13 12:21, Alex Gartrell:
> I couldn't figure out why this #ifdef existed so I looked around upstream
> and it's not there.  It seems to build just fine without it.
> 
> Signed-off-by: Alex Gartrell <agartrell@fb.com>
> ---
>  lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
> index a582f52..d58e1f3 100644
> --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
> +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
> @@ -472,12 +472,10 @@ static inline u16 igb_desc_unused(const struct igb_ring *ring)
>  	return ((ntc > ntu) ? 0 : ring->count) + ntc - ntu - 1;
>  }
>  
> -#ifdef CONFIG_BQL
>  static inline struct netdev_queue *txring_txq(const struct igb_ring *tx_ring)
>  {
>  	return netdev_get_tx_queue(tx_ring->netdev, tx_ring->queue_index);
>  }
> -#endif /* CONFIG_BQL */
>  
>  // #ifdef EXT_THERMAL_SENSOR_SUPPORT
>  // #ifdef IGB_PROCFS
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] eal: remove unnecessary #ifdef CONFIG_BQL
  2015-03-13 19:21 [dpdk-dev] [PATCH] eal: remove unnecessary #ifdef CONFIG_BQL Alex Gartrell
  2015-03-23 11:27 ` Thomas Monjalon
@ 2015-03-24  1:03 ` Zhang, Helin
  1 sibling, 0 replies; 3+ messages in thread
From: Zhang, Helin @ 2015-03-24  1:03 UTC (permalink / raw)
  To: Alex Gartrell, dev; +Cc: kernel-team

Hi Alex

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Alex Gartrell
> Sent: Saturday, March 14, 2015 3:22 AM
> To: dev@dpdk.org
> Cc: kernel-team@fb.com
> Subject: [dpdk-dev] [PATCH] eal: remove unnecessary #ifdef CONFIG_BQL
> 
> I couldn't figure out why this #ifdef existed so I looked around upstream and it's
> not there.  It seems to build just fine without it.

You can see in igb/kcomat.h of below code section.

#ifndef CONFIG_BQL
#define netdev_tx_completed_queue(_q, _p, _b) do {} while (0)
#define netdev_completed_queue(_n, _p, _b) do {} while (0)
#define netdev_tx_sent_queue(_q, _b) do {} while (0)
#define netdev_sent_queue(_n, _b) do {} while (0)
#define netdev_tx_reset_queue(_q) do {} while (0)
#define netdev_reset_queue(_n) do {} while (0)
#endif

That means all callers of txring_txq() are conditional compiled. I don't think your
modifications are needed.

Regards,
Helin

> 
> Signed-off-by: Alex Gartrell <agartrell@fb.com>
> ---
>  lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
> b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
> index a582f52..d58e1f3 100644
> --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
> +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
> @@ -472,12 +472,10 @@ static inline u16 igb_desc_unused(const struct
> igb_ring *ring)
>  	return ((ntc > ntu) ? 0 : ring->count) + ntc - ntu - 1;  }
> 
> -#ifdef CONFIG_BQL
>  static inline struct netdev_queue *txring_txq(const struct igb_ring *tx_ring)
> {
>  	return netdev_get_tx_queue(tx_ring->netdev, tx_ring->queue_index);  }
> -#endif /* CONFIG_BQL */
> 
>  // #ifdef EXT_THERMAL_SENSOR_SUPPORT
>  // #ifdef IGB_PROCFS
> --
> Alex Gartrell <agartrell@fb.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-24  1:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-13 19:21 [dpdk-dev] [PATCH] eal: remove unnecessary #ifdef CONFIG_BQL Alex Gartrell
2015-03-23 11:27 ` Thomas Monjalon
2015-03-24  1:03 ` Zhang, Helin

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git