From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 3493C7E6A for ; Tue, 24 Mar 2015 02:03:10 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 23 Mar 2015 18:03:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,455,1422950400"; d="scan'208";a="703108914" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by orsmga002.jf.intel.com with ESMTP; 23 Mar 2015 18:03:08 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by KMSMSX153.gar.corp.intel.com (172.21.73.88) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 24 Mar 2015 09:03:06 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.149]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.111]) with mapi id 14.03.0224.002; Tue, 24 Mar 2015 09:03:05 +0800 From: "Zhang, Helin" To: Alex Gartrell , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] eal: remove unnecessary #ifdef CONFIG_BQL Thread-Index: AQHQXcMCd6DMecjXiES4AmarlD9FgZ0q37vQ Date: Tue, 24 Mar 2015 01:03:05 +0000 Message-ID: References: <1426274503-372191-1-git-send-email-agartrell@fb.com> In-Reply-To: <1426274503-372191-1-git-send-email-agartrell@fb.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "kernel-team@fb.com" Subject: Re: [dpdk-dev] [PATCH] eal: remove unnecessary #ifdef CONFIG_BQL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2015 01:03:10 -0000 Hi Alex > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Alex Gartrell > Sent: Saturday, March 14, 2015 3:22 AM > To: dev@dpdk.org > Cc: kernel-team@fb.com > Subject: [dpdk-dev] [PATCH] eal: remove unnecessary #ifdef CONFIG_BQL >=20 > I couldn't figure out why this #ifdef existed so I looked around upstream= and it's > not there. It seems to build just fine without it. You can see in igb/kcomat.h of below code section. #ifndef CONFIG_BQL #define netdev_tx_completed_queue(_q, _p, _b) do {} while (0) #define netdev_completed_queue(_n, _p, _b) do {} while (0) #define netdev_tx_sent_queue(_q, _b) do {} while (0) #define netdev_sent_queue(_n, _b) do {} while (0) #define netdev_tx_reset_queue(_q) do {} while (0) #define netdev_reset_queue(_n) do {} while (0) #endif That means all callers of txring_txq() are conditional compiled. I don't th= ink your modifications are needed. Regards, Helin >=20 > Signed-off-by: Alex Gartrell > --- > lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h > b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h > index a582f52..d58e1f3 100644 > --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h > +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h > @@ -472,12 +472,10 @@ static inline u16 igb_desc_unused(const struct > igb_ring *ring) > return ((ntc > ntu) ? 0 : ring->count) + ntc - ntu - 1; } >=20 > -#ifdef CONFIG_BQL > static inline struct netdev_queue *txring_txq(const struct igb_ring *tx_= ring) > { > return netdev_get_tx_queue(tx_ring->netdev, tx_ring->queue_index); } > -#endif /* CONFIG_BQL */ >=20 > // #ifdef EXT_THERMAL_SENSOR_SUPPORT > // #ifdef IGB_PROCFS > -- > Alex Gartrell