From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] i40e: remove ALLOW_LB flag on SRIOV vsi
Date: Tue, 24 Mar 2015 02:37:52 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8303E4@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1426836708-19861-1-git-send-email-jingjing.wu@intel.com>
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Friday, March 20, 2015 3:32 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing; Xu, HuilongX; Zhang, Helin
> Subject: [PATCH] i40e: remove ALLOW_LB flag on SRIOV vsi
>
> Disable VEB switching by removing ALLOW_LB on SRIOV vsi.
>
> If the source mac address of packet sent from VF is not listed in the VEB's mac
> table, the VEB will switch the packet back to the VF.
> It's a hardware issue. Enabling ALLOW_LB flag will block VF functions.
>
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
> ---
> lib/librte_pmd_i40e/i40e_ethdev.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c
> b/lib/librte_pmd_i40e/i40e_ethdev.c
> index cf6685e..28ea5dc 100644
> --- a/lib/librte_pmd_i40e/i40e_ethdev.c
> +++ b/lib/librte_pmd_i40e/i40e_ethdev.c
> @@ -3059,11 +3059,15 @@ i40e_vsi_setup(struct i40e_pf *pf,
> ctxt.connection_type = 0x1;
> ctxt.flags = I40E_AQ_VSI_TYPE_VF;
>
> - /* Configure switch ID */
> - ctxt.info.valid_sections |=
> - rte_cpu_to_le_16(I40E_AQ_VSI_PROP_SWITCH_VALID);
> - ctxt.info.switch_id =
> - rte_cpu_to_le_16(I40E_AQ_VSI_SW_ID_FLAG_ALLOW_LB);
> + /**
> + * Do not configure switch ID to enable VEB switch by
> + * I40E_AQ_VSI_SW_ID_FLAG_ALLOW_LB. Because in Fortville,
> + * if the source mac address of packet sent from VF is not
> + * listed in the VEB's mac table, the VEB will switch the
> + * packet back to the VF. Need to enable it when HW issue
> + * is fixed.
> + */
> +
> /* Configure port/vlan */
> ctxt.info.valid_sections |=
> rte_cpu_to_le_16(I40E_AQ_VSI_PROP_VLAN_VALID);
> --
> 1.9.3
next prev parent reply other threads:[~2015-03-24 2:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 7:31 Jingjing Wu
2015-03-24 2:37 ` Zhang, Helin [this message]
2015-03-27 10:35 ` Thomas Monjalon
2015-03-25 3:14 ` Xu, HuilongX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A8303E4@SHSMSX104.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).