DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] i40e: zero local variable
@ 2015-03-25 21:38 Jingjing Wu
  2015-03-26  1:03 ` Zhang, Helin
  0 siblings, 1 reply; 3+ messages in thread
From: Jingjing Wu @ 2015-03-25 21:38 UTC (permalink / raw)
  To: dev

This patch sets the local variable ctxt to zero to avoid uncertain
data causes error when creating a vsi for flow director.

Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
 lib/librte_pmd_i40e/i40e_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c
index cf6685e..80fc432 100644
--- a/lib/librte_pmd_i40e/i40e_ethdev.c
+++ b/lib/librte_pmd_i40e/i40e_ethdev.c
@@ -3120,6 +3120,7 @@ i40e_vsi_setup(struct i40e_pf *pf,
 		ctxt.info.valid_sections |=
 			rte_cpu_to_le_16(I40E_AQ_VSI_PROP_SCHED_VALID);
 	} else if (type == I40E_VSI_FDIR) {
+		memset(&ctxt, 0, sizeof(ctxt));
 		vsi->uplink_seid = uplink_vsi->uplink_seid;
 		ctxt.pf_num = hw->pf_id;
 		ctxt.vf_num = 0;
@@ -3143,7 +3144,7 @@ i40e_vsi_setup(struct i40e_pf *pf,
 
 	if (vsi->type != I40E_VSI_MAIN) {
 		ret = i40e_aq_add_vsi(hw, &ctxt, NULL);
-		if (ret) {
+		if (ret != I40E_SUCCESS) {
 			PMD_DRV_LOG(ERR, "add vsi failed, aq_err=%d",
 				    hw->aq.asq_last_status);
 			goto fail_msix_alloc;
-- 
1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] i40e: zero local variable
  2015-03-25 21:38 [dpdk-dev] [PATCH] i40e: zero local variable Jingjing Wu
@ 2015-03-26  1:03 ` Zhang, Helin
  2015-03-27 10:34   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Helin @ 2015-03-26  1:03 UTC (permalink / raw)
  To: Wu, Jingjing, dev



> -----Original Message-----
> From: Wu, Jingjing
> Sent: Thursday, March 26, 2015 5:38 AM
> To: dev@dpdk.org
> Cc: Wu, Jingjing; Zhang, Helin; Cao, Min
> Subject: [PATCH] i40e: zero local variable
> 
> This patch sets the local variable ctxt to zero to avoid uncertain data causes
> error when creating a vsi for flow director.
> 
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>

> ---
>  lib/librte_pmd_i40e/i40e_ethdev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c
> b/lib/librte_pmd_i40e/i40e_ethdev.c
> index cf6685e..80fc432 100644
> --- a/lib/librte_pmd_i40e/i40e_ethdev.c
> +++ b/lib/librte_pmd_i40e/i40e_ethdev.c
> @@ -3120,6 +3120,7 @@ i40e_vsi_setup(struct i40e_pf *pf,
>  		ctxt.info.valid_sections |=
>  			rte_cpu_to_le_16(I40E_AQ_VSI_PROP_SCHED_VALID);
>  	} else if (type == I40E_VSI_FDIR) {
> +		memset(&ctxt, 0, sizeof(ctxt));
>  		vsi->uplink_seid = uplink_vsi->uplink_seid;
>  		ctxt.pf_num = hw->pf_id;
>  		ctxt.vf_num = 0;
> @@ -3143,7 +3144,7 @@ i40e_vsi_setup(struct i40e_pf *pf,
> 
>  	if (vsi->type != I40E_VSI_MAIN) {
>  		ret = i40e_aq_add_vsi(hw, &ctxt, NULL);
> -		if (ret) {
> +		if (ret != I40E_SUCCESS) {
>  			PMD_DRV_LOG(ERR, "add vsi failed, aq_err=%d",
>  				    hw->aq.asq_last_status);
>  			goto fail_msix_alloc;
> --
> 1.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] i40e: zero local variable
  2015-03-26  1:03 ` Zhang, Helin
@ 2015-03-27 10:34   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-03-27 10:34 UTC (permalink / raw)
  To: Wu, Jingjing; +Cc: dev

> > This patch sets the local variable ctxt to zero to avoid uncertain data causes
> > error when creating a vsi for flow director.
> > 
> > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-27 10:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-25 21:38 [dpdk-dev] [PATCH] i40e: zero local variable Jingjing Wu
2015-03-26  1:03 ` Zhang, Helin
2015-03-27 10:34   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git