From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1077D6A94 for ; Wed, 1 Apr 2015 03:26:18 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 31 Mar 2015 18:26:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,503,1422950400"; d="scan'208";a="707041621" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga002.jf.intel.com with ESMTP; 31 Mar 2015 18:26:16 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 1 Apr 2015 09:26:16 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.204]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.80]) with mapi id 14.03.0224.002; Wed, 1 Apr 2015 09:26:14 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] i40e: fix the issue reported by klocwork Thread-Index: AQHQRrY/pys7VfnIx0WOy7RCS0oHF502ZXfA///BsICAAYCTIA== Date: Wed, 1 Apr 2015 01:26:14 +0000 Message-ID: References: <1423740143-29708-1-git-send-email-jingjing.wu@intel.com> <2026242.YxCcPjBAVc@xps13> In-Reply-To: <2026242.YxCcPjBAVc@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] i40e: fix the issue reported by klocwork X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2015 01:26:19 -0000 Hi Thomas Actually it is a bug fix. It would be better to be put in R2.0. It may not crash, as it just possibly read something out of range. I am wai= ting the test report from our validation team, and then I will merge that. = Thanks for your patience! Regards, Helin > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, March 31, 2015 6:28 PM > To: Zhang, Helin > Cc: dev@dpdk.org; Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH] i40e: fix the issue reported by klocwork >=20 > Hi Helin, >=20 > > > Klocwork reports array 'src_offset' may use index 16. > > > In function i40e_srcoff_to_flx_pit, index j + 1 can reach > > > I40E_FDIR_MAX_FLEX_LEN. > > > This patch fixes this issue to avoid array bound. > > > > > > Signed-off-by: Jingjing Wu > > Acked-by: Helin Zhang >=20 > Please confirm it's a real bug which needs to be fixed in 2.0, and/or you= are sure > this patch won't bring a new problem. >=20 > Thanks