Re: [dpdk-dev] [PATCH 03/18] i40e: adjustment of register definitions and relevant

["Zhang, Helin" <helin.zhang@intel.com>]

Hi Thomas

New version is needed, as previous version has some code piece which shouldn't be present there.

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, April 28, 2015 1:17 AM
> To: Zhang, Helin
> Cc: dev@dpdk.org; Kenguva, Monica; Murray, Steven J; Shih, Chiu-Pi
> Subject: Re: [dpdk-dev] [PATCH 03/18] i40e: adjustment of register definitions
> and relevant
> 
> 2015-04-20 16:22, Helin Zhang:
> > More register definitions and their relevant masks are added
> > publically. Also few useless macros are deleted.
> >
> > Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> > ---
> >  lib/librte_pmd_i40e/i40e/i40e_register.h | 1981
> > +++++++++++++++++++++++++++++-
> 
> All these values are not used in the driver, right?
Driver read/write some of registers defined in this header file. All registers and their
relevant can be used by drivers, as these registers are treated as public registers.
Of cause there are registers which is for internal use only.

> 
> > --- a/lib/librte_pmd_i40e/i40e_ethdev.c
> > +++ b/lib/librte_pmd_i40e/i40e_ethdev.c
> > @@ -1269,9 +1269,6 @@ i40e_dev_stats_get(struct rte_eth_dev *dev,
> struct rte_eth_stats *stats)
> >  			    I40E_GLPRT_BPTCL(hw->port),
> >  			    pf->offset_loaded, &os->eth.tx_broadcast,
> >  			    &ns->eth.tx_broadcast);
> > -	i40e_stat_update_32(hw, I40E_GLPRT_TDPC(hw->port),
> > -			    pf->offset_loaded, &os->eth.tx_discards,
> > -			    &ns->eth.tx_discards);
> 
> The relation between this deletion and the rest of the patch is weird.
All the registers defined in i40e_registers.h are public, though may not already been
used in driver. It is not so weird that one of the deleted registers was being used in driver.

Regards,
Helin