From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id DA441C46C for ; Tue, 28 Apr 2015 04:31:01 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 27 Apr 2015 19:31:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,661,1422950400"; d="scan'208";a="701869155" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by fmsmga001.fm.intel.com with ESMTP; 27 Apr 2015 19:30:58 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by KMSMSX153.gar.corp.intel.com (172.21.73.88) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 28 Apr 2015 10:29:17 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.162]) by shsmsx102.ccr.corp.intel.com ([10.239.4.154]) with mapi id 14.03.0224.002; Tue, 28 Apr 2015 10:29:16 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 03/18] i40e: adjustment of register definitions and relevant Thread-Index: AQHQgQ4Lj+GGnkmo0UOvzaIIDTlXf51hsi3g Date: Tue, 28 Apr 2015 02:29:16 +0000 Message-ID: References: <1429518150-28098-1-git-send-email-helin.zhang@intel.com> <1429518150-28098-4-git-send-email-helin.zhang@intel.com> <1998049.eU2MTJspAg@xps13> In-Reply-To: <1998049.eU2MTJspAg@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , "Murray, Steven J" , "Shih, Chiu-Pi" , "Kenguva, Monica" Subject: Re: [dpdk-dev] [PATCH 03/18] i40e: adjustment of register definitions and relevant X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Apr 2015 02:31:02 -0000 Hi Thomas New version is needed, as previous version has some code piece which should= n't be present there. > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, April 28, 2015 1:17 AM > To: Zhang, Helin > Cc: dev@dpdk.org; Kenguva, Monica; Murray, Steven J; Shih, Chiu-Pi > Subject: Re: [dpdk-dev] [PATCH 03/18] i40e: adjustment of register defini= tions > and relevant >=20 > 2015-04-20 16:22, Helin Zhang: > > More register definitions and their relevant masks are added > > publically. Also few useless macros are deleted. > > > > Signed-off-by: Helin Zhang > > --- > > lib/librte_pmd_i40e/i40e/i40e_register.h | 1981 > > +++++++++++++++++++++++++++++- >=20 > All these values are not used in the driver, right? Driver read/write some of registers defined in this header file. All regist= ers and their relevant can be used by drivers, as these registers are treated as public r= egisters. Of cause there are registers which is for internal use only. >=20 > > --- a/lib/librte_pmd_i40e/i40e_ethdev.c > > +++ b/lib/librte_pmd_i40e/i40e_ethdev.c > > @@ -1269,9 +1269,6 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, > struct rte_eth_stats *stats) > > I40E_GLPRT_BPTCL(hw->port), > > pf->offset_loaded, &os->eth.tx_broadcast, > > &ns->eth.tx_broadcast); > > - i40e_stat_update_32(hw, I40E_GLPRT_TDPC(hw->port), > > - pf->offset_loaded, &os->eth.tx_discards, > > - &ns->eth.tx_discards); >=20 > The relation between this deletion and the rest of the patch is weird. All the registers defined in i40e_registers.h are public, though may not al= ready been used in driver. It is not so weird that one of the deleted registers was be= ing used in driver. Regards, Helin