From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <helin.zhang@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 3CDE3C4C8
 for <dev@dpdk.org>; Tue, 28 Apr 2015 04:34:11 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga102.jf.intel.com with ESMTP; 27 Apr 2015 19:34:10 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,661,1422950400"; d="scan'208";a="686614952"
Received: from pgsmsx108.gar.corp.intel.com ([10.221.44.103])
 by orsmga001.jf.intel.com with ESMTP; 27 Apr 2015 19:34:09 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 PGSMSX108.gar.corp.intel.com (10.221.44.103) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Tue, 28 Apr 2015 10:34:06 +0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.162]) by
 SHSMSX101.ccr.corp.intel.com ([10.239.4.153]) with mapi id 14.03.0224.002;
 Tue, 28 Apr 2015 10:34:05 +0800
From: "Zhang, Helin" <helin.zhang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH 12/18] i40e: enhancements of AQ commands and
 common interfaces
Thread-Index: AQHQgQ9tv4jjrpwbE0uXUCEpypaT9Z1htWWA
Date: Tue, 28 Apr 2015 02:34:04 +0000
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8555D0@SHSMSX104.ccr.corp.intel.com>
References: <1429518150-28098-1-git-send-email-helin.zhang@intel.com>
 <1429518150-28098-13-git-send-email-helin.zhang@intel.com>
 <4170175.P1QKHMmDD1@xps13>
In-Reply-To: <4170175.P1QKHMmDD1@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Murray,
 Steven J" <steven.j.murray@intel.com>, "Shih,
 Chiu-Pi" <chiu-pi.shih@intel.com>, "Kenguva,
 Monica" <monica.kenguva@intel.com>
Subject: Re: [dpdk-dev] [PATCH 12/18] i40e: enhancements of AQ commands and
 common interfaces
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Apr 2015 02:34:11 -0000



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, April 28, 2015 1:27 AM
> To: Zhang, Helin
> Cc: dev@dpdk.org; Kenguva, Monica; Murray, Steven J; Shih, Chiu-Pi
> Subject: Re: [dpdk-dev] [PATCH 12/18] i40e: enhancements of AQ commands
> and common interfaces
>=20
> 2015-04-20 16:22, Helin Zhang:
> > 'LE16_TO_CPU' was added in 'i40e_debug_aq()' to support big-endian and
> > little endian correctly. Fix of determing the PF number was added for
> > 'i40e_init_shared_code()', which can solve the issue of PF
> > pass-through. Also enhancements were added for 'i40e_led_get()'
> > and 'i40e_led_set()'. 'i40e_update_link_info()' was removed and
> > replaced by 'i40e_aq_get_link_info()' directly.
> > 'i40e_aq_debug_read_register()' was added for reading internal
> > registers for debug purpose.
>=20
> It seems there are really several patches in one.
> Please split to allow good tracking.
Yes, agree.

Regards,
Helin