From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <helin.zhang@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 85E03C4D2
 for <dev@dpdk.org>; Tue, 28 Apr 2015 04:34:58 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga101.fm.intel.com with ESMTP; 27 Apr 2015 19:34:57 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,661,1422950400"; d="scan'208";a="562818150"
Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78])
 by orsmga003.jf.intel.com with ESMTP; 27 Apr 2015 19:34:57 -0700
Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by
 PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Tue, 28 Apr 2015 10:34:55 +0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.162]) by
 SHSMSX103.ccr.corp.intel.com ([10.239.4.69]) with mapi id 14.03.0224.002;
 Tue, 28 Apr 2015 10:34:55 +0800
From: "Zhang, Helin" <helin.zhang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH 13/18] i40e: replacement of
 'i40e_debug_read_register()'
Thread-Index: AQHQgQ++vDLG031Os06NLzE4KbLEI51htZ7w
Date: Tue, 28 Apr 2015 02:34:54 +0000
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8555EC@SHSMSX104.ccr.corp.intel.com>
References: <1429518150-28098-1-git-send-email-helin.zhang@intel.com>
 <1429518150-28098-14-git-send-email-helin.zhang@intel.com>
 <1498171.E9UuRyUjTK@xps13>
In-Reply-To: <1498171.E9UuRyUjTK@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Murray,
 Steven J" <steven.j.murray@intel.com>, "Shih,
 Chiu-Pi" <chiu-pi.shih@intel.com>, "Kenguva,
 Monica" <monica.kenguva@intel.com>
Subject: Re: [dpdk-dev] [PATCH 13/18] i40e: replacement of
 'i40e_debug_read_register()'
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Apr 2015 02:34:59 -0000



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, April 28, 2015 1:29 AM
> To: Zhang, Helin
> Cc: dev@dpdk.org; Kenguva, Monica; Murray, Steven J; Shih, Chiu-Pi
> Subject: Re: [dpdk-dev] [PATCH 13/18] i40e: replacement of
> 'i40e_debug_read_register()'
>=20
> 2015-04-20 16:22, Helin Zhang:
> > As base driver provides 'i40e_aq_debug_read_register()', the same
> > functional interface of 'i40e_debug_read_register()' can be replaced.
> >
> > Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> > ---
> >  lib/librte_pmd_i40e/i40e_ethdev.c | 22 ++--------------------
> >  1 file changed, 2 insertions(+), 20 deletions(-)
>=20
> It should be merged with the patch introducing the function in the base d=
river.
> So it will be easier to check what changed.

OK. Agree with you!

Regards,
Helin