From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <helin.zhang@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 3A0675698
 for <dev@dpdk.org>; Tue, 19 May 2015 16:13:15 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga102.fm.intel.com with ESMTP; 19 May 2015 07:12:57 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,458,1427785200"; d="scan'208";a="731778993"
Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96])
 by orsmga002.jf.intel.com with ESMTP; 19 May 2015 07:12:55 -0700
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 PGSMSX105.gar.corp.intel.com (10.221.44.96) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Tue, 19 May 2015 22:12:54 +0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.94]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.180]) with mapi id 14.03.0224.002;
 Tue, 19 May 2015 22:12:53 +0800
From: "Zhang, Helin" <helin.zhang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v3 0/2] fix compile with ICC and clang
Thread-Index: AQHQkh9EqYcQGRa/sEaAAi48kJ/NPp2DV3iA
Date: Tue, 19 May 2015 14:12:53 +0000
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8693F4@SHSMSX104.ccr.corp.intel.com>
References: <1431961409-22252-1-git-send-email-helin.zhang@intel.com>
 <1431963656-22836-1-git-send-email-helin.zhang@intel.com>
 <20150518154325.GA8740@bricha3-MOBL3> <3255170.m2Jvvj9c1g@xps13>
In-Reply-To: <3255170.m2Jvvj9c1g@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 0/2] fix compile with ICC and clang
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 May 2015 14:13:15 -0000

Thomas, thank you!

- Helin

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, May 19, 2015 6:33 PM
> To: Zhang, Helin
> Cc: dev@dpdk.org; Richardson, Bruce
> Subject: Re: [dpdk-dev] [PATCH v3 0/2] fix compile with ICC and clang
>=20
> 2015-05-18 16:43, Bruce Richardson:
> > On Mon, May 18, 2015 at 11:40:54PM +0800, Helin Zhang wrote:
> > > Compile warnings on ICC and clang can be found, and treated as
> errors.
> > > Disabling those warnings forcedly can fix them.
> > >
> > > v2 changes:
> > > Added the fix for the compile error on clang.
> > >
> > > v3 changes:
> > > Reworded the commit titles.
> >
> > Series Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>=20
> Applied, thanks
> I reworded the commit message and added reference to the breaking
> commit:
> 	http://dpdk.org/browse/dpdk/commit/?id=3Dff5c3960017cf
> Please consider giving this kind of explanation when fixing things,
> especially for special handling of base drivers.