From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <helin.zhang@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by dpdk.org (Postfix) with ESMTP id 6D7359AD8
for <dev@dpdk.org>; Tue, 2 Jun 2015 03:45:06 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by fmsmga101.fm.intel.com with ESMTP; 01 Jun 2015 18:45:05 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,536,1427785200"; d="scan'208";a="501290662"
Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88])
by FMSMGA003.fm.intel.com with ESMTP; 01 Jun 2015 18:45:04 -0700
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
KMSMSX153.gar.corp.intel.com (172.21.73.88) with Microsoft SMTP Server (TLS)
id 14.3.224.2; Tue, 2 Jun 2015 09:45:03 +0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.94]) by
SHSMSX151.ccr.corp.intel.com ([169.254.3.180]) with mapi id 14.03.0224.002;
Tue, 2 Jun 2015 09:45:02 +0800
From: "Zhang, Helin" <helin.zhang@intel.com>
To: Olivier MATZ <olivier.matz@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH 1/5] ixgbe: remove a discarded source line
Thread-Index: AQHQnEgPfJWqxqqzjEWgLQSBLhX8Sp2YcsvA
Date: Tue, 2 Jun 2015 01:45:02 +0000
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A86E45A@SHSMSX104.ccr.corp.intel.com>
References: <1430793143-3610-1-git-send-email-helin.zhang@intel.com>
<1432629400-25303-1-git-send-email-helin.zhang@intel.com>
<1432629400-25303-2-git-send-email-helin.zhang@intel.com>
<556C1CD4.7030604@6wind.com>
In-Reply-To: <556C1CD4.7030604@6wind.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/5] ixgbe: remove a discarded source line
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Jun 2015 01:45:06 -0000
> -----Original Message-----
> From: Olivier MATZ [mailto:olivier.matz@6wind.com]
> Sent: Monday, June 1, 2015 4:50 PM
> To: Zhang, Helin; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/5] ixgbe: remove a discarded source line
>=20
> Hi Helin,
>=20
> On 05/26/2015 10:36 AM, Helin Zhang wrote:
> > Little endian to CPU order conversion had been added for reading vlan
> > tag from RX descriptor, while its original source line was forgotten
> > to delete. That's a discarded source line and should be deleted.
> >
> > Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> > ---
> > drivers/net/ixgbe/ixgbe_rxtx.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c
> > b/drivers/net/ixgbe/ixgbe_rxtx.c index 4f9ab22..041c544 100644
> > --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> > @@ -981,7 +981,6 @@ ixgbe_rx_scan_hw_ring(struct ixgbe_rx_queue *rxq)
> > pkt_len =3D (uint16_t)(rxdp[j].wb.upper.length - rxq->crc_len);
> > mb->data_len =3D pkt_len;
> > mb->pkt_len =3D pkt_len;
> > - mb->vlan_tci =3D rxdp[j].wb.upper.vlan;
> > mb->vlan_tci =3D rte_le_to_cpu_16(rxdp[j].wb.upper.vlan);
> >
> > /* convert descriptor fields to rte mbuf flags */
> >
>=20
> Maybe the following should be added in the commit log:
> Fixes: 23fcffe8ffac ("ixgbe: fix id and hash with flow director")
Agree, will add it. Thanks!
- Helin
>=20
> Acked-by: Olivier Matz <olivier.matz@6wind.com>