From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 51636C2FC for ; Tue, 2 Jun 2015 07:49:03 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 01 Jun 2015 22:49:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,538,1427785200"; d="scan'208";a="501358454" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by FMSMGA003.fm.intel.com with ESMTP; 01 Jun 2015 22:49:01 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by PGSMSX107.gar.corp.intel.com (10.221.44.105) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 2 Jun 2015 13:48:43 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.94]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.50]) with mapi id 14.03.0224.002; Tue, 2 Jun 2015 13:48:41 +0800 From: "Zhang, Helin" To: "simon.kagstrom@netinsight.net" Thread-Topic: [dpdk-dev] [PATCH / RFC] kni: Add set_rx_mode callback to handle multicast groups Thread-Index: AQHQiMhQhanhrsVTq0eM1gRBqOC9d52YuyLw//+bTQCAAIbDIA== Date: Tue, 2 Jun 2015 05:48:41 +0000 Message-ID: References: <20150507151754.1620c4cb@miho> <556D4282.6040309@netinsight.net> In-Reply-To: <556D4282.6040309@netinsight.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH / RFC] kni: Add set_rx_mode callback to handle multicast groups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2015 05:49:03 -0000 > -----Original Message----- > From: Simon K=E5gstr=F6m [mailto:simon.kagstrom@netinsight.net] > Sent: Tuesday, June 2, 2015 1:44 PM > To: Zhang, Helin; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH / RFC] kni: Add set_rx_mode callback to ha= ndle > multicast groups >=20 > On 2015-06-02 05:44, Zhang, Helin wrote: > >> -----Original Message----- > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Simon Kagstrom > >> Sent: Thursday, May 7, 2015 9:18 PM > >> To: dev@dpdk.org > >> Subject: [dpdk-dev] [PATCH / RFC] kni: Add set_rx_mode callback to > >> handle multicast groups > >> > >> This is needed to add / remove interfaces in multicast groups via the = ip tool. > > Could you help to explain with more details of why it is needed? >=20 > We did some (very basic) tests with IGMP, which involves adding multicast > addresses to ETH interfaces. This is done via the ip tool, an example can= be found > on e.g., >=20 >=20 > http://superuser.com/questions/324824/linux-built-in-or-open-source-progr= am- > to-join-multicast-group >=20 > and this will fail on KNI interfaces with the current code because of an > unimplemented ioctl (as Stephen Hemminger said earlier). The patch simply= adds > an empty callback so that the ioctl succeeds, and this is the same thing = as the > Linux tap interface does (so I think it should be enough for KNI as well)= . Yes, the root cause "null ioctl causes the failure" should be added in the = commit log for future reference by others. I am OK for the reason, please add the details to the commit logs. Thanks, Helin >=20 >=20 > If you want, I can update the patch with a bit more description (somethin= g like > the above). >=20 > // Simon