From: "Zhang, Helin" <helin.zhang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/9] kni: fix whitespace
Date: Fri, 5 Jun 2015 03:00:55 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A870EC1@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <4522406.UrXfWM9kLK@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, June 4, 2015 10:52 PM
> To: Zhang, Helin
> Cc: dev@dpdk.org; Stephen Hemminger
> Subject: Re: [dpdk-dev] [PATCH 1/9] kni: fix whitespace
>
> 2015-06-04 07:43, Stephen Hemminger:
> > From: Stephen Hemminger <shemming@brocade.com>
> >
> > Ran this code base through a script which:
> > - removes trailing whitespace
> > - removes space before tabs
> > - removes blank lines at end of file
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > .../linuxapp/kni/ethtool/igb/e1000_api.c | 1 -
> > .../linuxapp/kni/ethtool/igb/e1000_manage.c | 2 -
> > .../linuxapp/kni/ethtool/igb/e1000_mbx.c | 1 -
> > .../linuxapp/kni/ethtool/igb/e1000_nvm.c | 2 -
> > lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h | 2 +-
> > .../linuxapp/kni/ethtool/igb/igb_debugfs.c | 1 -
> > .../linuxapp/kni/ethtool/igb/igb_ethtool.c | 26 ++++++------
> > lib/librte_eal/linuxapp/kni/ethtool/igb/igb_main.c | 2 +-
> > .../linuxapp/kni/ethtool/igb/igb_param.c | 3 +-
> > .../linuxapp/kni/ethtool/igb/igb_procfs.c | 46
> +++++++++++-----------
> > .../linuxapp/kni/ethtool/igb/igb_regtest.h | 2 -
> > lib/librte_eal/linuxapp/kni/ethtool/igb/igb_vmdq.c | 1 -
> > lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 4 +-
> > .../linuxapp/kni/ethtool/igb/kcompat_ethtool.c | 11 +++---
> > .../linuxapp/kni/ethtool/ixgbe/ixgbe_82599.c | 1 -
> > .../linuxapp/kni/ethtool/ixgbe/ixgbe_api.c | 1 -
> > .../linuxapp/kni/ethtool/ixgbe/ixgbe_common.c | 1 -
> > .../linuxapp/kni/ethtool/ixgbe/ixgbe_main.c | 5 ---
> > .../linuxapp/kni/ethtool/ixgbe/ixgbe_sriov.h | 1 -
> > .../linuxapp/kni/ethtool/ixgbe/ixgbe_x540.c | 7 ++--
> > .../linuxapp/kni/ethtool/ixgbe/kcompat.h | 2 +-
>
> Helin, do you approve patching kni base driver?
Thomas, I have acked it, also another one in the same patch set for e1000 driver.
next prev parent reply other threads:[~2015-06-05 3:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 14:43 [dpdk-dev] [PATCH 0/9] whitespace cleanups Stephen Hemminger
2015-06-04 14:43 ` [dpdk-dev] [PATCH 1/9] kni: fix whitespace Stephen Hemminger
2015-06-04 14:51 ` Thomas Monjalon
2015-06-05 3:00 ` Zhang, Helin [this message]
2015-06-05 2:58 ` Zhang, Helin
2015-06-04 14:43 ` [dpdk-dev] [PATCH 2/9] eal: " Stephen Hemminger
2015-06-04 14:43 ` [dpdk-dev] [PATCH 3/9] cmdline: " Stephen Hemminger
2015-06-04 14:43 ` [dpdk-dev] [PATCH 4/9] vhost: fix trailing whitespace Stephen Hemminger
2015-06-04 14:43 ` [dpdk-dev] [PATCH 5/9] lib: fix misc whitespace Stephen Hemminger
2015-06-04 14:43 ` [dpdk-dev] [PATCH 6/9] app: fix whitespace Stephen Hemminger
2015-06-04 14:43 ` [dpdk-dev] [PATCH 7/9] examples: " Stephen Hemminger
2015-06-04 14:43 ` [dpdk-dev] [PATCH 8/9] mk, scripts: remove useless blank lines Stephen Hemminger
2015-06-04 14:43 ` [dpdk-dev] [PATCH 9/9] drivers: fix whitespace Stephen Hemminger
2015-06-05 2:59 ` Zhang, Helin
2015-06-11 15:37 ` [dpdk-dev] [PATCH 0/9] whitespace cleanups Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A870EC1@SHSMSX104.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).