From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6FA6A2A07 for ; Fri, 5 Jun 2015 08:22:43 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 04 Jun 2015 23:22:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,556,1427785200"; d="scan'208";a="737522734" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by fmsmga002.fm.intel.com with ESMTP; 04 Jun 2015 23:22:42 -0700 Received: from kmsmsx154.gar.corp.intel.com (172.21.73.14) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 5 Jun 2015 14:22:01 +0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by KMSMSX154.gar.corp.intel.com (172.21.73.14) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 5 Jun 2015 14:22:00 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.94]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.23]) with mapi id 14.03.0224.002; Fri, 5 Jun 2015 14:21:53 +0800 From: "Zhang, Helin" To: Neil Horman Thread-Topic: [dpdk-dev] [PATCH 1/6] ethdev: add an field for querying hash key size Thread-Index: AQHQnsc/ZI8Ny6YMREyTq5z2a323MZ2dcaIw Date: Fri, 5 Jun 2015 06:21:52 +0000 Message-ID: References: <1433379638-32715-1-git-send-email-helin.zhang@intel.com> <1433379638-32715-2-git-send-email-helin.zhang@intel.com> <20150604130510.GB24585@hmsreliant.think-freely.org> In-Reply-To: <20150604130510.GB24585@hmsreliant.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/6] ethdev: add an field for querying hash key size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2015 06:22:43 -0000 Hi Neil Yes, thank you very much for the comments! I realized the ABI issue after I sent out the patch. I think even I put the= new one the end of this structure, it may also have issue. I'd like to have this change announced and then get it merged. That means I= 'd like to make this change and follow the policy and process. Regards, Helin > -----Original Message----- > From: Neil Horman [mailto:nhorman@tuxdriver.com] > Sent: Thursday, June 4, 2015 9:05 PM > To: Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/6] ethdev: add an field for querying has= h key > size >=20 > On Thu, Jun 04, 2015 at 09:00:33AM +0800, Helin Zhang wrote: > > To support querying hash key size per port, an new field of > > 'hash_key_size' was added in 'struct rte_eth_dev_info' for storing > > hash key size in bytes. > > > > Signed-off-by: Helin Zhang > > --- > > lib/librte_ether/rte_ethdev.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/librte_ether/rte_ethdev.h > > b/lib/librte_ether/rte_ethdev.h index 16dbe00..004b05a 100644 > > --- a/lib/librte_ether/rte_ethdev.h > > +++ b/lib/librte_ether/rte_ethdev.h > > @@ -916,6 +916,7 @@ struct rte_eth_dev_info { > > uint16_t max_vmdq_pools; /**< Maximum number of VMDq pools. */ > > uint32_t rx_offload_capa; /**< Device RX offload capabilities. */ > > uint32_t tx_offload_capa; /**< Device TX offload capabilities. */ > > + uint8_t hash_key_size; /**< Hash key size in bytes */ > > uint16_t reta_size; > > /**< Device redirection table size, the total number of entries. */ > > /** Bit mask of RSS offloads, the bit offset also means flow type */ > > -- > > 1.9.3 > > > > >=20 > You'll need to at least move this to the end of the structure to avoid AB= I breakage, > but even then, since the examples statically allocate this struct on the = stack, you > need to worry about previously compiled applications not having enough sp= ace > allocated. Is there a hole in the struct that this can fit into to avoid= changing the > other member offsets? > Neil