DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Helin" <helin.zhang@intel.com>
To: Wenfeng Liu <liuwf@arraynetworks.com.cn>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] kni: Passing task_pid_vnr(current) to get_net_ns_by_pid() in kni_ioctl_create()
Date: Wed, 17 Jun 2015 03:58:38 +0000	[thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A882E2A@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1434341253-3227-1-git-send-email-liuwf@arraynetworks.com.cn>



> -----Original Message-----
> From: Wenfeng Liu [mailto:liuwf@arraynetworks.com.cn]
> Sent: Monday, June 15, 2015 12:08 PM
> To: Zhang, Helin; dev@dpdk.org
> Subject: [PATCH] kni: Passing task_pid_vnr(current) to get_net_ns_by_pid() in
> kni_ioctl_create()
> 
> In containers like docker, current->pid returns current process's global PID
> instead of its own PID under containers's PID namespace, and
> get_net_ns_by_pid() suppose to accept a virtual PID under its own namespace,
> so we should use task_pid_vnr(current) to get current process's virtual PID
> instead of current->pid.
> 
> Signed-off-by: Wenfeng Liu <liuwf@arraynetworks.com.cn>
> ---
>  lib/librte_eal/linuxapp/kni/kni_misc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c
> b/lib/librte_eal/linuxapp/kni/kni_misc.c
> index 1935d32..18fb677 100644
> --- a/lib/librte_eal/linuxapp/kni/kni_misc.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_misc.c
> @@ -359,7 +359,7 @@ kni_ioctl_create(unsigned int ioctl_num, unsigned long
> ioctl_param)
>  		return -EBUSY;
>  	}
> 
> -	net = get_net_ns_by_pid(current->pid);
> +	net = get_net_ns_by_pid(task_pid_vnr(current));
Have you tried it on a very old kernel versions? E.g. 2.6.33

Helin

>  	if (IS_ERR(net)) {
>  		free_netdev(net_dev);
>  		return PTR_ERR(net);
> --
> 1.8.3.1

  reply	other threads:[~2015-06-17  3:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-15  4:07 Wenfeng Liu
2015-06-17  3:58 ` Zhang, Helin [this message]
2015-06-17  5:43   ` [dpdk-dev] 答复: " Wenfeng Liu
2015-06-17  5:49     ` [dpdk-dev] " Zhang, Helin
2015-06-17  5:51 ` Zhang, Helin
2015-06-17 13:08   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A882E2A@SHSMSX104.ccr.corp.intel.com \
    --to=helin.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=liuwf@arraynetworks.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).