From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C49D6C564 for ; Thu, 25 Jun 2015 10:31:41 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 25 Jun 2015 01:31:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,675,1427785200"; d="scan'208";a="717376544" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by orsmga001.jf.intel.com with ESMTP; 25 Jun 2015 01:31:39 -0700 Received: from kmsmsx154.gar.corp.intel.com (172.21.73.14) by PGSMSX107.gar.corp.intel.com (10.221.44.105) with Microsoft SMTP Server (TLS) id 14.3.224.2; Thu, 25 Jun 2015 16:31:38 +0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by KMSMSX154.gar.corp.intel.com (172.21.73.14) with Microsoft SMTP Server (TLS) id 14.3.224.2; Thu, 25 Jun 2015 16:31:37 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.129]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.146]) with mapi id 14.03.0224.002; Thu, 25 Jun 2015 16:31:36 +0800 From: "Zhang, Helin" To: Neil Horman Thread-Topic: [PATCH v3 2/7] mbuf: use the reserved 16 bits for double vlan Thread-Index: AQHQpBTeg+8HKUCcY0y8KhIVxHtc6J28+dwA Date: Thu, 25 Jun 2015 08:31:36 +0000 Message-ID: References: <1433214967-22247-1-git-send-email-helin.zhang@intel.com> <1434006240-7271-1-git-send-email-helin.zhang@intel.com> <1434006240-7271-3-git-send-email-helin.zhang@intel.com> In-Reply-To: <1434006240-7271-3-git-send-email-helin.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 2/7] mbuf: use the reserved 16 bits for double vlan X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2015 08:31:42 -0000 Hi Neil > -----Original Message----- > From: Zhang, Helin > Sent: Thursday, June 11, 2015 3:04 PM > To: dev@dpdk.org > Cc: Cao, Min; Liu, Jijiang; Wu, Jingjing; Ananyev, Konstantin; Richardson= , Bruce; > olivier.matz@6wind.com; Zhang, Helin > Subject: [PATCH v3 2/7] mbuf: use the reserved 16 bits for double vlan >=20 > Use the reserved 16 bits in rte_mbuf structure for the outer vlan, also a= dd QinQ > offloading flags for both RX and TX sides. >=20 > Signed-off-by: Helin Zhang > --- > lib/librte_mbuf/rte_mbuf.h | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) >=20 > v2 changes: > * Fixed a typo. >=20 > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h inde= x > ab6de67..84fe181 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -101,11 +101,17 @@ extern "C" { > #define PKT_RX_TUNNEL_IPV6_HDR (1ULL << 12) /**< RX tunnel packet with > IPv6 header. */ > #define PKT_RX_FDIR_ID (1ULL << 13) /**< FD id reported if FDIR ma= tch. > */ > #define PKT_RX_FDIR_FLX (1ULL << 14) /**< Flexible bytes reported i= f > FDIR match. */ > +#define PKT_RX_QINQ_PKT (1ULL << 15) /**< RX packet with double > VLAN stripped. */ > /* add new RX flags here */ >=20 > /* add new TX flags here */ >=20 > /** > + * Second VLAN insertion (QinQ) flag. > + */ > +#define PKT_TX_QINQ_PKT (1ULL << 49) /**< TX packet with double > VLAN inserted. */ > + > +/** > * TCP segmentation offload. To enable this offload feature for a > * packet to be transmitted on hardware supporting TSO: > * - set the PKT_TX_TCP_SEG flag in mbuf->ol_flags (this flag implies @= @ > -279,7 +285,7 @@ struct rte_mbuf { > uint16_t data_len; /**< Amount of data in segment buffer. */ > uint32_t pkt_len; /**< Total pkt len: sum of all segments. */ > uint16_t vlan_tci; /**< VLAN Tag Control Identifier (CPU order) = */ > - uint16_t reserved; > + uint16_t vlan_tci_outer; /**< Outer VLAN Tag Control Identifier (CPU > +order) */ Do you think here is a ABI break or not? Just using the reserved 16 bits, w= hich was intended for the second_vlan_tag. Thanks in advance! I did not see any "Incompatible" reported by validate_abi.sh. Regards, Helin > union { > uint32_t rss; /**< RSS hash result if RSS enabled */ > struct { > @@ -777,6 +783,7 @@ static inline void rte_pktmbuf_reset(struct rte_mbuf = *m) > m->pkt_len =3D 0; > m->tx_offload =3D 0; > m->vlan_tci =3D 0; > + m->vlan_tci_outer =3D 0; > m->nb_segs =3D 1; > m->port =3D 0xff; >=20 > @@ -849,6 +856,7 @@ static inline void rte_pktmbuf_attach(struct rte_mbuf= *mi, > struct rte_mbuf *m) > mi->data_len =3D m->data_len; > mi->port =3D m->port; > mi->vlan_tci =3D m->vlan_tci; > + mi->vlan_tci_outer =3D m->vlan_tci_outer; > mi->tx_offload =3D m->tx_offload; > mi->hash =3D m->hash; >=20 > -- > 1.9.3