From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 9713A2A5B for ; Mon, 13 Jul 2015 18:32:50 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 13 Jul 2015 09:32:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,463,1432623600"; d="scan'208";a="761575044" Received: from kmsmsx154.gar.corp.intel.com ([172.21.73.14]) by fmsmga002.fm.intel.com with ESMTP; 13 Jul 2015 09:32:48 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by KMSMSX154.gar.corp.intel.com (172.21.73.14) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 14 Jul 2015 00:32:45 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.129]) by shsmsx102.ccr.corp.intel.com ([169.254.2.165]) with mapi id 14.03.0224.002; Tue, 14 Jul 2015 00:32:43 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v10 19/19] mbuf: remove old packet type bit masks Thread-Index: AQHQvYcJvwB1XBJ+KEqIc+UcNUM37J3ZlZew//967oCAAIcGoA== Date: Mon, 13 Jul 2015 16:32:42 +0000 Message-ID: References: <1435912347-19499-1-git-send-email-helin.zhang@intel.com> <2161590.Y1eMLetJSj@xps13> <1862129.zWrQIqxoo8@xps13> In-Reply-To: <1862129.zWrQIqxoo8@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v10 19/19] mbuf: remove old packet type bit masks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2015 16:32:51 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, July 13, 2015 9:28 AM > To: Zhang, Helin > Cc: dev@dpdk.org; Adrien Mazarguil; Rahul Lakkireddy > Subject: Re: [dpdk-dev] [PATCH v10 19/19] mbuf: remove old packet type bi= t > masks >=20 > 2015-07-13 16:25, Zhang, Helin: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2015-07-10 00:31, Helin Zhang: > > > > As unified packet types are used instead, those old bit masks and > > > > the relevant macros for packet type indication need to be removed. > > > > > > It breaks mlx4 and cxgbe drivers. > [...] > > I think I have already reworked with that changes in v9 and v10 recentl= y. > > http://www.dpdk.org/dev/patchwork/patch/6253/ >=20 > No, your changes were for t4_ethrx_handler(). > Since recent cxgbe change, we also need to update process_responses(). OK. Thanks! It involves so many components. Thank you all for helping on unified packet type! - Helin >=20 > > > The cxgbe changes need to be updated after > > > 78fc1a716ae8 ("cxgbe: improve Rx performance") I suggest this update: > > > > > > --- a/drivers/net/cxgbe/sge.c > > > +++ b/drivers/net/cxgbe/sge.c > > > @@ -1419,7 +1419,11 @@ static int process_responses(struct sge_rspq > > > *q, int budget, > > > unmap_rx_buf(&rxq->fl); > > > > > > if (cpl->l2info & htonl(F_RXF_IP)) { > > > +#ifdef RTE_NEXT_ABI > > > + mbuf->packet_type =3D > > > +RTE_PTYPE_L3_IPV4; #else > > > pkt->ol_flags |=3D PKT_RX_IPV4_HDR; > > > +#endif > > > if (unlikely(!csum_ok)) > > > pkt->ol_flags |=3D > > > PKT_RX_IP_CKSUM_BAD; > > > > > > @@ -1427,7 +1431,11 @@ static int process_responses(struct sge_rspq > > > *q, int budget, > > > htonl(F_RXF_UDP | F_RXF_TCP)) > > > && !csum_ok) > > > pkt->ol_flags |=3D > > > PKT_RX_L4_CKSUM_BAD; > > > } else if (cpl->l2info & htonl(F_RXF_IP6)) { > > > +#ifdef RTE_NEXT_ABI > > > + mbuf->packet_type =3D > > > +RTE_PTYPE_L3_IPV6; #else > > > pkt->ol_flags |=3D PKT_RX_IPV6_HDR; > > > +#endif > > > } > > >=20