From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <helin.zhang@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 147F5C396
 for <dev@dpdk.org>; Wed, 29 Jul 2015 17:00:19 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga102.jf.intel.com with ESMTP; 29 Jul 2015 08:00:17 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,571,1432623600"; d="scan'208";a="532359027"
Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86])
 by FMSMGA003.fm.intel.com with ESMTP; 29 Jul 2015 08:00:17 -0700
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Wed, 29 Jul 2015 23:00:15 +0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.45]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.126]) with mapi id 14.03.0224.002;
 Wed, 29 Jul 2015 23:00:14 +0800
From: "Zhang, Helin" <helin.zhang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH] eal: fix build
Thread-Index: AQHQydeXddjgoqBxjkm9elnXC9Oksp3yihRg
Date: Wed, 29 Jul 2015 15:00:13 +0000
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8B6FE3@SHSMSX104.ccr.corp.intel.com>
References: <1438123707-26509-1-git-send-email-helin.zhang@intel.com>
 <4457109.BKbKVosbHQ@xps13>
In-Reply-To: <4457109.BKbKVosbHQ@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="windows-1256"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: fix build
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jul 2015 15:00:21 -0000

Hi Thomas

It was just an implicit declaration of function, when set CONFIG_RTE_PCI_CO=
NFIG=3Dy, as follows. Nobody else cares about it.

/home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_pci.c: =
In function =E2=80?rte_eal_pci_probe_one_driver=E2=80=99:
/home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_pci.c:1=
88:4: error: implicit declaration of function =E2=80?pci_config_space_set=
=E2=80=99 [-Werror=3Dimplicit-function-declaration]
    pci_config_space_set(dev);
    ^
/home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_pci.c:1=
88:4: error: nested extern declaration of =E2=80?pci_config_space_set=E2=80=
=99 [-Werror=3Dnested-externs]
cc1: all warnings being treated as errors
/home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/linuxapp/eal/eal_pci.c:56=
1:1: error: =E2=80?pci_config_space_set=E2=80=99 defined but not used [-Wer=
ror=3Dunused-function]
 pci_config_space_set(struct rte_pci_device *dev)
 ^
cc1: all warnings being treated as errors

Regards,
Helin

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, July 29, 2015 1:20 AM
> To: Zhang, Helin
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] eal: fix build
>=20
> 2015-07-29 06:48, Helin Zhang:
> > It fixes the build error of implicit declaration of function.
>=20
> What is the error?
> Please show the build log and describe the case when it happens (compiler=
,
> version).