From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A8A21C458 for ; Wed, 29 Jul 2015 18:12:18 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 29 Jul 2015 09:10:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,571,1432623600"; d="scan'208";a="772335329" Received: from pgsmsx103.gar.corp.intel.com ([10.221.44.82]) by fmsmga002.fm.intel.com with ESMTP; 29 Jul 2015 09:10:04 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by PGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP Server (TLS) id 14.3.224.2; Thu, 30 Jul 2015 00:10:02 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.45]) by shsmsx102.ccr.corp.intel.com ([169.254.2.126]) with mapi id 14.03.0224.002; Thu, 30 Jul 2015 00:10:01 +0800 From: "Zhang, Helin" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] eal: fix build Thread-Index: AQHQydeXddjgoqBxjkm9elnXC9Oksp3yihRg//98QICAAIZ/QP//iiqAgACHCUA= Date: Wed, 29 Jul 2015 16:10:01 +0000 Message-ID: References: <1438123707-26509-1-git-send-email-helin.zhang@intel.com> <55B8EBD1.5090104@intel.com> <3400596.gUZi4e9jS4@xps13> In-Reply-To: <3400596.gUZi4e9jS4@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] eal: fix build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2015 16:12:19 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, July 29, 2015 9:06 AM > To: Zhang, Helin > Cc: Gonzalez Monroy, Sergio; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] eal: fix build >=20 > 2015-07-29 15:09, Zhang, Helin: > > From: Gonzalez Monroy, Sergio > > > Fixes: 4d4ebca4 ("pci: merge probing and closing functions for linux > > > and bsd") > > > > > > The function rte_eal_pci_probe_one_driver, which calls > > > pci_config_space_set, was moved to eal_common_pci.c, but > > > pci_config_space_set was left in eal_pci.c with static specifier. > > > > Yes, that's the root cause. > > I am just have a thought that we may need to move all of those three > > functions together into eal_common_pci.c, which can avoid exporting tha= t > function. >=20 > No it is specific to Linux (implemented in igb_uio only). > But it may be moved to eal_common if you remove the igb_uio patch and use > the new functions to access to PCI config with UIO or VFIO: > http://dpdk.org/browse/dpdk/commit/?id=3D632b2d1deeed Yes, I agree. It should be moved into i40e PMD only according to the user c= onfigurations. Regards, Helin >=20 > This build fix will be applied for 2.1. > It is expected the above rework will be done for 2.2. > Thanks