From: "Zhang, Helin" <helin.zhang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] config files maintenance
Date: Fri, 31 Jul 2015 15:29:11 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8B8424@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <2490473.jjJga3lrlm@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, July 31, 2015 8:08 AM
> To: Zhang, Helin; Ananyev, Konstantin; Richardson, Bruce
> Cc: dev@dpdk.org
> Subject: config files maintenance
>
> Hi,
>
> Currently most of the build options are duplicated in 2 config files.
> They should be merged in a common file to avoid this kind of differences:
>
> --- config/common_bsdapp
> +++ config/common_linuxapp
> -CONFIG_RTE_IXGBE_INC_VECTOR=n
> +CONFIG_RTE_IXGBE_INC_VECTOR=y
> -CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE=n
> +CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=y
> -CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=n
> +CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=y
>
> Can we enable ixgbe SSE on BSD?
> CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE must be renamed to
> CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE, or can we remove this option?
> Can we remove i40e bulk alloc option?
As the receiving functions are different for bulk_alloc or not, we need this flag.
> Why IEEE1588 is disabled? Can we remove this option?
I think the reason was it wanted to show the best performance by default,
as more processing are needed for ieee1588 in fast path.
I agree with you that we may need to re-think it.
Thanks,
Helin
>
> Please help to fix it for the release 2.1.
>
> After fixing the config, we have to think about simplifying it in 2.2.
> It would be easier to have some kind of config overlays:
> config_base
> config_bsd
> config_linux
> config_osv
> config_gcc
> config_icc
> config_clang
> config_i686
> config_x86_64
> config_x86_x32
> config_ppc_64
> config_tile-tilegx
> Then the defconfig files would include the above files.
> Or better, we could allow some paramaters to make config:
> make config ARCH= OS= CC=
>
> Thoughts?
next prev parent reply other threads:[~2015-07-31 15:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 15:08 Thomas Monjalon
2015-07-31 15:29 ` Zhang, Helin [this message]
2015-07-31 15:31 ` Thomas Monjalon
2015-07-31 15:39 ` Zhang, Helin
2015-07-31 15:43 ` Thomas Monjalon
2015-07-31 16:34 ` Zhang, Helin
2015-07-31 15:41 ` Ananyev, Konstantin
2015-07-31 20:45 ` Thomas Monjalon
2015-07-31 21:11 ` [dpdk-dev] [PATCH 0/3] sync linux/bsd config options Thomas Monjalon
2015-07-31 21:11 ` [dpdk-dev] [PATCH 1/3] ixgbe: fix offload config option name Thomas Monjalon
2015-07-31 21:11 ` [dpdk-dev] [PATCH 2/3] config: enable same drivers options for linux and bsd Thomas Monjalon
2015-07-31 21:11 ` [dpdk-dev] [PATCH 3/3] config: remove kni options for bsd Thomas Monjalon
2015-07-31 21:24 ` Zhang, Helin
2015-08-03 10:44 ` [dpdk-dev] [PATCH 0/3] sync linux/bsd config options Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A8B8424@SHSMSX104.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).