From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <helin.zhang@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 5CC40C6F0
 for <dev@dpdk.org>; Fri, 31 Jul 2015 17:29:21 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga102.fm.intel.com with ESMTP; 31 Jul 2015 08:29:20 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,585,1432623600"; d="scan'208";a="775283774"
Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96])
 by orsmga002.jf.intel.com with ESMTP; 31 Jul 2015 08:29:14 -0700
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 PGSMSX105.gar.corp.intel.com (10.221.44.96) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Fri, 31 Jul 2015 23:29:13 +0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.45]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.126]) with mapi id 14.03.0224.002;
 Fri, 31 Jul 2015 23:29:12 +0800
From: "Zhang, Helin" <helin.zhang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, "Ananyev, Konstantin"
 <konstantin.ananyev@intel.com>, "Richardson, Bruce"
 <bruce.richardson@intel.com>
Thread-Topic: config files maintenance
Thread-Index: AQHQy6L2U6UVPprO9E6ycQAnRsT1/J31sekA
Date: Fri, 31 Jul 2015 15:29:11 +0000
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8B8424@SHSMSX104.ccr.corp.intel.com>
References: <2490473.jjJga3lrlm@xps13>
In-Reply-To: <2490473.jjJga3lrlm@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] config files maintenance
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Jul 2015 15:29:21 -0000



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, July 31, 2015 8:08 AM
> To: Zhang, Helin; Ananyev, Konstantin; Richardson, Bruce
> Cc: dev@dpdk.org
> Subject: config files maintenance
>=20
> Hi,
>=20
> Currently most of the build options are duplicated in 2 config files.
> They should be merged in a common file to avoid this kind of differences:
>=20
> --- config/common_bsdapp
> +++ config/common_linuxapp
> -CONFIG_RTE_IXGBE_INC_VECTOR=3Dn
> +CONFIG_RTE_IXGBE_INC_VECTOR=3Dy
> -CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE=3Dn
> +CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=3Dy
> -CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=3Dn
> +CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=3Dy
>=20
> Can we enable ixgbe SSE on BSD?
> CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE must be renamed to
> CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE, or can we remove this option?
> Can we remove i40e bulk alloc option?
As the receiving functions are different for bulk_alloc or not, we need thi=
s flag.

> Why IEEE1588 is disabled? Can we remove this option?
I think the reason was it wanted to show the best performance by default,
as more processing are needed for ieee1588 in fast path.
I agree with you that we may need to re-think it.

Thanks,
Helin

>=20
> Please help to fix it for the release 2.1.
>=20
> After fixing the config, we have to think about simplifying it in 2.2.
> It would be easier to have some kind of config overlays:
> 	config_base
> 	config_bsd
> 	config_linux
> 	config_osv
> 	config_gcc
> 	config_icc
> 	config_clang
> 	config_i686
> 	config_x86_64
> 	config_x86_x32
> 	config_ppc_64
> 	config_tile-tilegx
> Then the defconfig files would include the above files.
> Or better, we could allow some paramaters to make config:
> 	make config ARCH=3D OS=3D CC=3D
>=20
> Thoughts?