From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 268552716 for ; Fri, 7 Aug 2015 22:37:27 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 07 Aug 2015 13:37:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,630,1432623600"; d="scan'208";a="621391677" Received: from pgsmsx106.gar.corp.intel.com ([10.221.44.98]) by orsmga003.jf.intel.com with ESMTP; 07 Aug 2015 13:37:27 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by PGSMSX106.gar.corp.intel.com (10.221.44.98) with Microsoft SMTP Server (TLS) id 14.3.224.2; Sat, 8 Aug 2015 04:37:25 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.45]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.18]) with mapi id 14.03.0224.002; Sat, 8 Aug 2015 04:37:23 +0800 From: "Zhang, Helin" To: "Qiu, Michael" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding Thread-Index: AQHQ0MFsS7hGUtd0hU690hnHtNOYL54A/2RQ Date: Fri, 7 Aug 2015 20:37:23 +0000 Message-ID: References: <1438918156-1259-1-git-send-email-michael.qiu@intel.com> <533710CFB86FA344BFBF2D6802E6028604703736@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <533710CFB86FA344BFBF2D6802E6028604703736@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2015 20:37:28 -0000 > -----Original Message----- > From: Qiu, Michael > Sent: Friday, August 7, 2015 11:53 AM > To: Zhang, Helin; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwardin= g >=20 > On 2015/8/7 9:06, Zhang, Helin wrote: > > > >> -----Original Message----- > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu > >> Sent: Thursday, August 6, 2015 8:29 PM > >> To: dev@dpdk.org > >> Subject: [dpdk-dev] [PATCH] testpmd: modify the mac of csum > >> forwarding > >> > >> For some ethnet-switch like intel RRC, all the packet forwarded out > >> by DPDK will be dropped in switch side, so the packet generator will n= ever > receive the packet. > > Is it because of anti-sproof? E.g. When the hardware found that the > > dest mac is the port itself, then it will be dropped during TX. > > You need to tell the root cause, and why we need to modify like this. >=20 > Actually, it is not the hardware from PEP(PCI End Point) side, but the sw= itch side. >=20 > The TX is OK for DPDK and NIC, but in switch, it receives the packet and = try to > forward it, but the dest mac is the same as the NIC which transmit this p= acket. > So switch will drop it as "Loopback Suppression Drop" in RRC. This should= only > happen when switch forwarding packets using dest mac. >=20 >=20 > > > >> Signed-off-by: Michael Qiu > >> --- > >> app/test-pmd/csumonly.c | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index > >> 1bf3485..bf8af1d 100644 > >> --- a/app/test-pmd/csumonly.c > >> +++ b/app/test-pmd/csumonly.c > >> @@ -550,6 +550,10 @@ pkt_burst_checksum_forward(struct fwd_stream > *fs) > >> * and inner headers */ > >> > >> eth_hdr =3D rte_pktmbuf_mtod(m, struct ether_hdr *); > >> + ether_addr_copy(&peer_eth_addrs[fs->peer_addr], > >> + ð_hdr->d_addr); > >> + ether_addr_copy(&ports[fs->tx_port].eth_addr, > >> + ð_hdr->s_addr); > > Is it really necessary? Why other NICs do not need this? >=20 > Because other NICs is connect directly to packet generator...., if we usi= ng switch > to connect the generator and the NICs, I think it will need this. There are 'iofwd' and 'mac' mode in testpmd, and mac forware will modify th= e dest mac before transmitting the packet. They are for different cases. Why not use mac forwarding mode for your testing, and just keep it as is? Regards, Helin >=20 > Thanks, > Michael > > > >> parse_ethernet(eth_hdr, &info); > >> l3_hdr =3D (char *)eth_hdr + info.l2_len; > >> > >> -- > >> 1.9.3 > >