DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Helin" <helin.zhang@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] BUG - KNI broken in 4.2 kernel
Date: Thu, 27 Aug 2015 17:53:50 +0000	[thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8E79CF@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20150827104543.0138ab53@urahara>



> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Thursday, August 27, 2015 10:46 AM
> To: Zhang, Helin
> Cc: Jay Rolette; dev@dpdk.org
> Subject: Re: [dpdk-dev] BUG - KNI broken in 4.2 kernel
> 
> On Thu, 27 Aug 2015 15:56:16 +0000
> "Zhang, Helin" <helin.zhang@intel.com> wrote:
> 
> > Based on my experience, only one or two users asked for ethtool support, then
> we have it. Before that time, we don’t have KNI ethtool support.
> > I did not mean who uses KNI does not care about it, I mean for those users who
> don’t use KNI, they shouldn’t be bothered by the KNI compilation issues.
> That’s why I was thinking if we can disable it by default, but not remove it.
> >
> > Regards,
> > Helin
> 
> Can KNI instead use DPDK hooks to provide generic ethtool semantics.
> That way it would work with all hardware.
I am not sure if I understood your idea correctly.
My personal point is that the best KNI ethtool support should be processed in user space application.
Sure if we want to support standard Linux ethtool commands, the KNI kernel driver should have a mechanism to work together with user space application. Is that what you said of hooks?
But this may need huge efforts on it.
Sure ideas on ethtool support improvements are always welcome!

Regards,
Helin

  reply	other threads:[~2015-08-27 17:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27  0:15 Stephen Hemminger
2015-08-27  8:41 ` Thomas Monjalon
2015-08-27  9:58   ` De Lara Guarch, Pablo
2015-08-27 15:23 ` Zhang, Helin
2015-08-27 15:49   ` Jay Rolette
2015-08-27 15:56     ` Zhang, Helin
2015-08-27 17:45       ` Stephen Hemminger
2015-08-27 17:53         ` Zhang, Helin [this message]
2015-08-28 12:44         ` Bruce Richardson
2015-08-28 15:48           ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A8E79CF@SHSMSX104.ccr.corp.intel.com \
    --to=helin.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).