From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 604545A58 for ; Tue, 1 Sep 2015 07:36:56 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 31 Aug 2015 22:36:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,446,1437462000"; d="scan'208";a="779988494" Received: from kmsmsx154.gar.corp.intel.com ([172.21.73.14]) by fmsmga001.fm.intel.com with ESMTP; 31 Aug 2015 22:36:54 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by KMSMSX154.gar.corp.intel.com (172.21.73.14) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 1 Sep 2015 13:34:29 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.210]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.143]) with mapi id 14.03.0224.002; Tue, 1 Sep 2015 13:34:28 +0800 From: "Zhang, Helin" To: Vlad Zolotarov , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1] net: i40e: add VLAN tag size to RXMAX Thread-Index: AQHQ47gmoVyjzFRO/E+fypiKEskiEp4nJONg Date: Tue, 1 Sep 2015 05:34:28 +0000 Message-ID: References: <1441003305-24055-1-git-send-email-vladz@cloudius-systems.com> In-Reply-To: <1441003305-24055-1-git-send-email-vladz@cloudius-systems.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] net: i40e: add VLAN tag size to RXMAX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Sep 2015 05:36:56 -0000 > -----Original Message----- > From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com] > Sent: Monday, August 31, 2015 2:42 PM > To: dev@dpdk.org > Cc: Zhang, Helin; Ananyev, Konstantin; avi@cloudius-systems.com; Vlad > Zolotarov > Subject: [dpdk-dev] [PATCH v1] net: i40e: add VLAN tag size to RXMAX >=20 > HW requires it regardless the presence of the VLAN tag in the received fr= ame. > Otherwise Rx frames are being filtered out on the MTU-4 boundary. Maximum packet length could have different meanings from MTU. I agree with you to have it be regardless of vlan tag length. >=20 > Signed-off-by: Vlad Zolotarov > --- > drivers/net/i40e/i40e_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c = index > eae4ab0..22aaeb1 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -3156,7 +3156,7 @@ i40e_rx_queue_init(struct i40e_rx_queue *rxq) > rx_ctx.hsplit_0 =3D I40E_HEADER_SPLIT_ALL; > else > rx_ctx.hsplit_0 =3D I40E_HEADER_SPLIT_NONE; > - rx_ctx.rxmax =3D rxq->max_pkt_len; > + rx_ctx.rxmax =3D rxq->max_pkt_len + I40E_VLAN_TAG_SIZE; It needs to take into account the double vlan case, and also VF case. It seems it needs more code changes. Thank you for the contribution! Regards, Helin > rx_ctx.tphrdesc_ena =3D 1; > rx_ctx.tphwdesc_ena =3D 1; > rx_ctx.tphdata_ena =3D 1; > -- > 2.1.0