From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 3584C8E64 for ; Fri, 30 Oct 2015 02:58:46 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 29 Oct 2015 18:58:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,217,1444719600"; d="scan'208";a="822785588" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 29 Oct 2015 18:58:46 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 29 Oct 2015 18:58:44 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.194]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.204]) with mapi id 14.03.0248.002; Fri, 30 Oct 2015 09:58:42 +0800 From: "Zhang, Helin" To: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v6 1/3] i40e: RSS/FD granularity configuration Thread-Index: AQHREi2ZNY2H2qVkjE6uo15/t+i6Zp6DR/dw Date: Fri, 30 Oct 2015 01:58:42 +0000 Message-ID: References: <1446091744-16758-1-git-send-email-helin.zhang@intel.com> <1446098572-4409-1-git-send-email-helin.zhang@intel.com> <1446098572-4409-2-git-send-email-helin.zhang@intel.com> <20151029093831.GA6160@bricha3-MOBL3> In-Reply-To: <20151029093831.GA6160@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v6 1/3] i40e: RSS/FD granularity configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2015 01:58:46 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Thursday, October 29, 2015 5:39 PM > To: Zhang, Helin > Cc: dev@dpdk.org; Pei, Yulong > Subject: Re: [dpdk-dev] [PATCH v6 1/3] i40e: RSS/FD granularity configura= tion >=20 > On Thu, Oct 29, 2015 at 02:02:50PM +0800, Helin Zhang wrote: > > The default input set of fields of a received packet are loaded from > > firmware, which cannot be modified even users want to use different > > fields for RSS or flow director. Here adds more flexibilities of > > selecting packet fields for hash calculation or flow director for > > users. > > > > Signed-off-by: Helin Zhang > > Signed-off-by: Andrey Chilikin > > --- > > drivers/net/i40e/i40e_ethdev.c | 742 > ++++++++++++++++++++++++++++++++++++++++ > > drivers/net/i40e/i40e_ethdev.h | 7 + > > drivers/net/i40e/i40e_fdir.c | 31 ++ > > lib/librte_ether/rte_eth_ctrl.h | 114 +++++- > > 4 files changed, 890 insertions(+), 4 deletions(-) > > > > > @@ -672,6 +776,8 @@ struct rte_eth_hash_filter_info { > > uint8_t enable; > > /** Global configurations of hash filter */ > > struct rte_eth_hash_global_conf global_conf; > > + /** Global configurations of hash filter input set */ > > + struct rte_eth_input_set_conf input_set_conf; > > } info; > > }; > > > Hi Helin, >=20 > Just to check: Does this change affect the size of the structure and caus= e ABI > issues? Bruce, you are right, there should be ABI issue with the structure size. Th= ank you very much! I will change the size of ' struct rte_eth_input_set_conf ' to smaller one,= and then no ABI issue this time. But I will announce ABI change to support configuring more than one input s= ets, and then make the change next time. /Helin >=20 > /Bruce